linux-acpi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [RFT][PATCH] PCI / ACPI: Do not require MSI support for PCIe native features
@ 2011-03-05 21:54 Rafael J. Wysocki
  2011-03-14 18:26 ` Sarah Sharp
  0 siblings, 1 reply; 19+ messages in thread
From: Rafael J. Wysocki @ 2011-03-05 21:54 UTC (permalink / raw)
  To: linux-pci, Sarah Sharp
  Cc: LKML, Jesse Barnes, ACPI Devel Mailing List, Len Brown,
	Matthew Garrett

From: Rafael J. Wysocki <rjw@sisk.pl>

After commit 415e12b2379239973feab91850b0dce985c6058a
(PCI/ACPI: Request _OSC control once for each root bridge (v3)) we
require MSI to be supported so that we use _OSC to request control
of PCIe native features (hotplug, AER, PME), but that appears to
be overkill and causes problems to happen on some systems.  For
this reason, request control of PCIe native features via _OSC
even if MSI support is not enabled.

Reported-by: Sarah Sharp <sarah.a.sharp@linux.intel.com>
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
---

Hi,

Sarah, please test this patch on your machine causing PCIe hotplug
problems on top of the patch from https://patchwork.kernel.org/patch/612171/
and on top of 2.6.38-rc6 or later.

Thanks,
Rafael

---
 drivers/acpi/pci_root.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Index: linux-2.6/drivers/acpi/pci_root.c
===================================================================
--- linux-2.6.orig/drivers/acpi/pci_root.c
+++ linux-2.6/drivers/acpi/pci_root.c
@@ -50,8 +50,7 @@ static int acpi_pci_root_start(struct ac
 
 #define ACPI_PCIE_REQ_SUPPORT (OSC_EXT_PCI_CONFIG_SUPPORT \
 				| OSC_ACTIVE_STATE_PWR_SUPPORT \
-				| OSC_CLOCK_PWR_CAPABILITY_SUPPORT \
-				| OSC_MSI_SUPPORT)
+				| OSC_CLOCK_PWR_CAPABILITY_SUPPORT)
 
 static const struct acpi_device_id root_device_ids[] = {
 	{"PNP0A03", 0},

^ permalink raw reply	[flat|nested] 19+ messages in thread
end of thread, other threads:[~2011-03-22  0:07 UTC | newest]

Thread overview: 19+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-05 21:54 [RFT][PATCH] PCI / ACPI: Do not require MSI support for PCIe native features Rafael J. Wysocki
2011-03-14 18:26 ` Sarah Sharp
2011-03-14 20:02   ` Rafael J. Wysocki
2011-03-14 20:19     ` Sarah Sharp
2011-03-14 20:37       ` Rafael J. Wysocki
2011-03-14 23:47         ` Sarah Sharp
2011-03-15  0:00           ` Rafael J. Wysocki
2011-03-15 19:05             ` Sarah Sharp
2011-03-17  0:19               ` Rafael J. Wysocki
2011-03-17  5:23                 ` Yinghai Lu
2011-03-17 21:22                   ` Rafael J. Wysocki
2011-03-17 21:56                     ` Sarah Sharp
2011-03-21 22:28                       ` Hot plug issue on 2.6.38 Sarah Sharp
2011-03-21 22:34                         ` Matthew Garrett
2011-03-21 23:31                           ` Sarah Sharp
2011-03-21 23:41                             ` Rafael J. Wysocki
2011-03-21 22:51                         ` Rafael J. Wysocki
2011-03-21 23:54                           ` Sarah Sharp
2011-03-22  0:07                             ` Rafael J. Wysocki

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).