Linux ACPI
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Florian Mickler <florian@mickler.org>
Cc: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
	Len Brown <lenb@kernel.org>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	kurup_avinash@yahoo.com, maciej.rutecki@gmail.com, rjw@sisk.pl,
	sedat.dilek@gmail.com
Subject: Re: [PATCH] x86, ioapic: move acpi_get_override_irq to acpi.c
Date: Tue, 12 Apr 2011 09:39:29 +0200	[thread overview]
Message-ID: <20110412073929.GA26892@elte.hu> (raw)
In-Reply-To: <1301672686-10096-1-git-send-email-florian@mickler.org>


* Florian Mickler <florian@mickler.org> wrote:

> In order to get rid of the ugly CONFIG_ACPI ifdef, we move
> the function acpi_get_override_irq into acpi.c and add a new
> helper function ioapic_get_irq to io_apic.c.
> 
> Signed-off-by: Florian Mickler <florian@mickler.org>
> Cc: Len Brown <lenb@kernel.org>
> Cc: "Eric W. Biederman" <ebiederm@xmission.com>
> Cc: kurup_avinash@yahoo.com
> Cc: maciej.rutecki@gmail.com
> Cc: rjw@sisk.pl
> Cc: sedat.dilek@gmail.com
> LKML-Reference: <1301558489-4198-1-git-send-email-florian@mickler.org>
> ---
> 
> Hi Ingo,
> 
> Instead of exporting find_irq_entry, irq_trigger and irq_polarity, I added a 
> new helper function 'ioapic_get_irq(..)' and exported that. 
> 
> Also I did it as a seperate commit, since it is more of a cleanup and the other 
> commit is already tested... hope this is ok. 

Yeah, looks good in principle.

Mind porting to the latest x86 devel tree and resend the patch? I tried to 
apply your patch but there's a conflict. You can find the tree at:

  http://people.redhat.com/mingo/tip.git/README

Thanks,

	Ingo

  parent reply	other threads:[~2011-04-12  7:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20110401075011.GD7594@elte.hu>
2011-04-01 15:44 ` [PATCH] x86, ioapic: move acpi_get_override_irq to acpi.c Florian Mickler
2011-04-01 16:26   ` Florian Mickler
2011-04-03 14:34     ` Florian Mickler
2011-04-04 15:00       ` Ingo Molnar
2011-04-12  7:39   ` Ingo Molnar [this message]
2011-04-12 19:53     ` Florian Mickler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110412073929.GA26892@elte.hu \
    --to=mingo@elte.hu \
    --cc=ebiederm@xmission.com \
    --cc=florian@mickler.org \
    --cc=kurup_avinash@yahoo.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maciej.rutecki@gmail.com \
    --cc=rjw@sisk.pl \
    --cc=sedat.dilek@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox