From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wu Fengguang Subject: Re: [RFC 1/4] HWPoison: add memory_failure_queue() Date: Thu, 21 Apr 2011 18:05:41 +0800 Message-ID: <20110421100541.GA991@localhost> References: <1303177419-22466-1-git-send-email-ying.huang@intel.com> <20110420090305.GB3761@localhost> <4DAFD0F2.5080708@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mga02.intel.com ([134.134.136.20]:39446 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750707Ab1DUKFz (ORCPT ); Thu, 21 Apr 2011 06:05:55 -0400 Content-Disposition: inline In-Reply-To: <4DAFD0F2.5080708@intel.com> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: "Huang, Ying" Cc: Len Brown , "linux-kernel@vger.kernel.org" , Andi Kleen , "Luck, Tony" , "linux-acpi@vger.kernel.org" , Andi Kleen , Andrew Morton On Thu, Apr 21, 2011 at 02:38:42PM +0800, Huang, Ying wrote: > Hi, Fengguang, > > On 04/20/2011 05:03 PM, Wu, Fengguang wrote: > >> + if (kfifo_put(&mf_cpu->fifo, &entry)) > >> + schedule_work_on(smp_processor_id(), &mf_cpu->work); > >> + else > >> + pr_err("Memory failure: buffer overflow when recovering memory failure at 0x%#lx\n", > >> + pfn); > > > > nitpick: "buffer overflow when recording memory failure at PFN ..."? > > Yes, in fact we are not recovering now. Or "s/recording/queuing/"? OK, that's fine. Thanks, Fengguang