From: Nicolas Kaiser <nikai@nikai.net>
To: Karthigan Srinivasan <karthigan.srinivasan@hp.com>
Cc: Len Brown <lenb@kernel.org>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/acpi/utils.c: Fixed coding style issues
Date: Thu, 21 Apr 2011 10:28:15 +0200 [thread overview]
Message-ID: <20110421102815.5abf133e@absol.kitzblitz> (raw)
In-Reply-To: <1303341624.11397.2.camel@ks-ubuntu>
* Karthigan Srinivasan <karthigan.srinivasan@hp.com>:
> Fixed brace and comment coding style issues in code.
>
> Signed-off-by: Karthigan Srinivasan <karthigan.srinivasan@hp.com>
> ---
> drivers/acpi/utils.c | 18 +++++++++---------
> 1 files changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/acpi/utils.c b/drivers/acpi/utils.c
> index b002a47..2cf81a1 100644
> --- a/drivers/acpi/utils.c
> +++ b/drivers/acpi/utils.c
> @@ -99,9 +99,9 @@ acpi_extract_package(union acpi_object *package,
>
> union acpi_object *element = &(package->package.elements[i]);
>
> - if (!element) {
> + if (!element)
^
You are introducing trailing whitespace.
> return AE_BAD_DATA;
> - }
> +
^^^^^^^^^^^^^
For every pair of braces you clean away, you're adding
two new coding style issues.
Best regards,
Nicolas Kaiser
next prev parent reply other threads:[~2011-04-21 8:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-20 23:20 [PATCH] drivers/acpi/utils.c: Fixed coding style issues Karthigan Srinivasan
2011-04-21 8:28 ` Nicolas Kaiser [this message]
2011-04-21 16:08 ` Karthigan Srinivasan
2011-05-02 22:16 ` Karthigan Srinivasan
2011-05-03 0:26 ` Joe Perches
2011-05-03 15:09 ` Karthigan Srinivasan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110421102815.5abf133e@absol.kitzblitz \
--to=nikai@nikai.net \
--cc=karthigan.srinivasan@hp.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox