From: Joern Heissler <linux-acpi@joern.heissler.de>
To: linux-acpi@vger.kernel.org
Subject: bug in acer-wmi.c, wmid3_set_device_status(), initialization of params.
Date: Tue, 31 May 2011 15:03:19 +1200 [thread overview]
Message-ID: <20110531030316.GE13559@joerntop> (raw)
Hello,
I think I have found a bug in acer-wmi.c,
commit 987dfbaa65b2c3568b85e29d2598da08a011ee09:
The function wmid3_set_device_status contains:
struct wmid3_gds_input_param params = {
.function_num = 0x1,
.hotkey_number = 0x01,
.devices = ACER_WMID3_GDS_WIRELESS &
ACER_WMID3_GDS_THREEG &
ACER_WMID3_GDS_WIMAX &
ACER_WMID3_GDS_BLUETOOTH,
};
(1<<0) & (1<<6) & (1<<7) & (1<<11) is zero. Meant bitwise or?
And could someone please update the driver to support my laptop?
See https://bugzilla.kernel.org/show_bug.cgi?id=36322 for details :-)
Cheery
Joern Heissler
next reply other threads:[~2011-05-31 3:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-31 3:03 Joern Heissler [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-05-31 3:39 bug in acer-wmi.c, wmid3_set_device_status(), initialization of params Joey Lee
2011-05-31 4:46 Joey Lee
2011-05-31 5:10 ` Joern Heissler
2011-05-31 6:12 ` Joey Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110531030316.GE13559@joerntop \
--to=linux-acpi@joern.heissler.de \
--cc=linux-acpi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox