From: Dominik Brodowski <linux@dominikbrodowski.net>
To: Len Brown <lenb@kernel.org>
Cc: linux-acpi@vger.kernel.org, cpufreq@vger.kernel.org,
Arjan van de Ven <arjan@infradead.org>
Subject: Re: [PATCH] acpi-cpufreq: remove unreliable get-frequency functions
Date: Tue, 7 Jun 2011 08:01:23 +0200 [thread overview]
Message-ID: <20110607060123.GA5333@isilmar-3.linta.de> (raw)
In-Reply-To: <20110607054226.GA22398@isilmar-3.linta.de>
A correction:
On Tue, Jun 07, 2011 at 07:42:26AM +0200, Dominik Brodowski wrote:
> > > Finally:
> > >
> > > > + policy->cur = data->freq_table[data->acpi_data->state].frequency;
> > >
> > > How do you know what state / frequency the CPU is running here?
> >
> > really the correct fix is for the upper level of cpufreq to
> > simply no export this value at all, or to export the value
> > that was last written. A driver should be free to decline
> > to supply any current value.
>
> You didn't answer the question of how it is assured that policy->cur is
> correctly initialized here.
I just checked, and if it is initialized wrongly here, it doesn't matter
much due to patch 4b31e774 .
Best,
Dominik
next prev parent reply other threads:[~2011-06-07 6:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-06 5:47 [PATCH] acpi-cpufreq: remove unreliable get-frequency functions Len Brown
2011-06-06 7:12 ` Dominik Brodowski
2011-06-07 4:07 ` Len Brown
2011-06-07 5:42 ` Dominik Brodowski
2011-06-07 6:01 ` Dominik Brodowski [this message]
2011-07-14 1:53 ` Len Brown
2011-07-16 22:49 ` [PATCH, RESEND] acpi-cpufreq: remove unreliable optional device.get() code Len Brown
2011-07-17 14:59 ` Dominik Brodowski
2011-07-21 9:48 ` Thomas Renninger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110607060123.GA5333@isilmar-3.linta.de \
--to=linux@dominikbrodowski.net \
--cc=arjan@infradead.org \
--cc=cpufreq@vger.kernel.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox