Re: [PATCH] ACPI, APEI, Add APEI _OSC support

Don Zickus
2011-06-13T14:50:19Z

On Wed, May 25, 2011 at 02:05:38PM +0800, Huang Ying wrote:
> In APEI firmware first mode, hardware error is reported by hardware to
> firmware firstly, then firmware reports the error to Linux in a GHES
> error record via POLL/SCI/IRQ/NMI etc.
>
> This may result in some issues if OS has no full APEI support. So
> some firmware implementation will work in a back-compatible mode by
> default. Where firmware will only notify OS in old-fashion, without
> GHES record. For example, for a fatal hardware error, only NMI is
> signaled, no GHES record.
>
> To gain full APEI power on these machines, a special APEI _OSC needs
> to be evaluated to tell firmware that Linux has full APEI support.
> This patch add the APEI _OSC support.

Using an Intel box I have over at RedHat, I was able to use this patch to
get error injection (EINJ) to provide me a GHES record. Prior to this
patch I would just get unknown NMIs.

Talking with Matthew Garret, I guess it seems that uuids like this are
typical for ACPI.

I can't speak for all the ACPI parts, but the patch looks simple and
corret from my perspective.

Reviewed-and-Tested-by: Don Zickus <dzickus@redhat.com>