Re: [PATCH] ACPI, APEI, Add APEI _OSC support

Huang Ying
2011-06-17T00:57:11Z

On 06/16/2011 09:57 AM, Matthew Garrett wrote:
> On Thu, Jun 16, 2011 at 09:55:58AM +0800, Huang Ying wrote:
>> On 06/16/2011 09:38 AM, Matthew Garrett wrote:
>>> I think we probably need to make the HEST decision early, and use that
>>> to decide how to make the generic call. Our experience has been that
>>> many firmware vendors only expect _OSC to be called once with any given
>>> UUID - multiple calls can result in unexpected behaviour.
>>
>> acpi_bus_osc_support is called via subsys_initcall. It is a little hard
>> to do all checking before that. Is it possible to call
>> acpi_bus_osc_support later?
>
> Yeah, this is going to be a problem. We have the HEST available at this
> point so we ought to be able to parse it, though. I'll take a look
> tomorrow.

We can check the HEST table before _OSC evaluating. But it is much
harder to check software part, because we have implemented GHES support
(Generic Hardware Error Source, the handler of firmware first mode
hardware error notification) as device driver and module.

So I think we can do that in 2 steps. At first, we just enable WHEA
UUID, because that is easier to do. Then we find a way to implement
"APEI bit" in generic _OSC call. Do you think that is a good idea?

Best Regards,
Huang Ying