From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Matthieu CASTET <castet.matthieu@free.fr>,
Linux Kernel list <linux-kernel@vger.kernel.org>,
linux-acpi@vger.kernel.org, x86@kernel.org
Subject: Re: [PATCH 1/2] merge 32 and 64 realmode wakeup code
Date: Sun, 3 Jul 2011 08:50:32 +0200 [thread overview]
Message-ID: <201107030850.32457.rjw@sisk.pl> (raw)
In-Reply-To: <4E0F9C3F.8020907@zytor.com>
On Sunday, July 03, 2011, H. Peter Anvin wrote:
> On 07/02/2011 10:43 AM, Matthieu CASTET wrote:
> > - this mean less ifdef in code
> > - we could remove now unused field in wakeup_header (pmode_*)
> >
> > Signed-off-by: Matthieu CASTET <castet.matthieu@free.fr>
> > ---
> > arch/x86/kernel/acpi/realmode/wakeup.S | 26 --------------------------
> > arch/x86/kernel/acpi/sleep.c | 27 ++++++++++-----------------
> > arch/x86/kernel/trampoline_32.S | 4 ----
> > 3 files changed, 10 insertions(+), 47 deletions(-)
> >
>
> Looks great to me. Rafael?
I don't have any immediate complaints. Please feel free to add my ACK
to the patches.
Thanks,
Rafael
next prev parent reply other threads:[~2011-07-03 6:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-02 17:43 [PATCH 1/2] merge 32 and 64 realmode wakeup code Matthieu CASTET
2011-07-02 17:43 ` [PATCH 2/2] clean acpi wakeup code after merge Matthieu CASTET
2011-07-02 22:31 ` [PATCH 1/2] merge 32 and 64 realmode wakeup code H. Peter Anvin
2011-07-03 6:50 ` Rafael J. Wysocki [this message]
2011-07-03 20:52 ` matthieu castet
2011-07-03 21:19 ` H. Peter Anvin
-- strict thread matches above, loose matches on Subject: below --
2011-12-16 20:13 Matthieu CASTET
2012-01-13 18:01 ` Pavel Machek
2011-03-13 22:03 matthieu castet
2011-03-13 22:31 ` Rafael J. Wysocki
2011-03-13 23:06 ` H. Peter Anvin
2011-03-15 19:31 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201107030850.32457.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=castet.matthieu@free.fr \
--cc=hpa@zytor.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).