[patch]acpi: add missing _OSI strings -- resend

[patch]acpi: add missing _OSI strings -- resend

[Shaohua Li]

Last post (Jun 14 ) is lost, resend.


Linux supports some optional features, but it should notify BIOS about them
in _OSI method. Currently Linux doesn't notify any, which might make such
features not work because BIOS doesn't know about them.

Reported-by: "Jarosz, Sebastian" <sebastian.jarosz@intel.com>
Signed-off-by: Shaohua Li <shaohua.li@intel.com>

diff --git a/drivers/acpi/osl.c b/drivers/acpi/osl.c
index 52ca964..a305115 100644
--- a/drivers/acpi/osl.c
+++ b/drivers/acpi/osl.c
@@ -1083,7 +1083,13 @@ struct osi_setup_entry {
 	bool enable;
 };
 
-static struct osi_setup_entry __initdata osi_setup_entries[OSI_STRING_ENTRIES_MAX];
+static struct osi_setup_entry __initdata
+		osi_setup_entries[OSI_STRING_ENTRIES_MAX] = {
+	{"Module Device", true},
+	{"Processor Device", true},
+	{"3.0 _SCP Extensions", true},
+	{"Processor Aggregator Device", true},
+};
 
 void __init acpi_osi_setup(char *str)
 {

Re: [patch]acpi: add missing _OSI strings -- resend

[Matthew Garrett]

On Mon, Jul 04, 2011 at 01:23:20PM +0800, Shaohua Li wrote:

> Linux supports some optional features, but it should notify BIOS about them
> in _OSI method. Currently Linux doesn't notify any, which might make such
> features not work because BIOS doesn't know about them.
> 
> Reported-by: "Jarosz, Sebastian" <sebastian.jarosz@intel.com>
> Signed-off-by: Shaohua Li <shaohua.li@intel.com>

I can't find any systems in my DSDT collection that actually use these, 
but in terms of correctness:

Acked-by: Matthew Garrett <mjg@redhat.com>

-- 
Matthew Garrett | mjg59@srcf.ucam.org

Re: [patch]acpi: add missing _OSI strings -- resend

[Andrew Morton]

On Mon, 04 Jul 2011 13:23:20 +0800
Shaohua Li <shaohua.li@intel.com> wrote:

> Last post (Jun 14 ) is lost, resend.
> 
> 
> Linux supports some optional features, but it should notify BIOS about them
> in _OSI method. Currently Linux doesn't notify any, which might make such
> features not work because BIOS doesn't know about them.
> 

This is a bit vague.  Are any machines actually fixed or improved by
this change?  Is so, can we please see a full description of the
behaviour change?

Thanks.

> --- a/drivers/acpi/osl.c
> +++ b/drivers/acpi/osl.c
> @@ -1083,7 +1083,13 @@ struct osi_setup_entry {
>  	bool enable;
>  };
>  
> -static struct osi_setup_entry __initdata osi_setup_entries[OSI_STRING_ENTRIES_MAX];
> +static struct osi_setup_entry __initdata
> +		osi_setup_entries[OSI_STRING_ENTRIES_MAX] = {
> +	{"Module Device", true},
> +	{"Processor Device", true},
> +	{"3.0 _SCP Extensions", true},
> +	{"Processor Aggregator Device", true},
> +};
>  
>  void __init acpi_osi_setup(char *str)
>  {
> 

Re: [patch]acpi: add missing _OSI strings -- resend

[Shaohua Li]

On Wed, 2011-07-06 at 06:08 +0800, Andrew Morton wrote:
> On Mon, 04 Jul 2011 13:23:20 +0800
> Shaohua Li <shaohua.li@intel.com> wrote:
> 
> > Last post (Jun 14 ) is lost, resend.
> > 
> > 
> > Linux supports some optional features, but it should notify BIOS about them
> > in _OSI method. Currently Linux doesn't notify any, which might make such
> > features not work because BIOS doesn't know about them.
> > 
> 
> This is a bit vague.  Are any machines actually fixed or improved by
> this change?  Is so, can we please see a full description of the
> behaviour change?
I haven't a system which needs the fix. Jarosz Sebastian has a system
which needs this to make ACPI processor aggregator device work.

Thanks,
Shaohua

RE: [patch]acpi: add missing _OSI strings -- resend

[Jarosz, Sebastian]

Shaohua, Andrew,

Yes, I have the platform to test his patch and I'll do it as soon as possible.

Regards,
Sebastian

-----Original Message-----
From: Li, Shaohua 
Sent: Wednesday, July 06, 2011 2:29 AM
To: Andrew Morton
Cc: linux acpi; Brown, Len; Jarosz, Sebastian
Subject: Re: [patch]acpi: add missing _OSI strings -- resend

On Wed, 2011-07-06 at 06:08 +0800, Andrew Morton wrote:
> On Mon, 04 Jul 2011 13:23:20 +0800
> Shaohua Li <shaohua.li@intel.com> wrote:
> 
> > Last post (Jun 14 ) is lost, resend.
> > 
> > 
> > Linux supports some optional features, but it should notify BIOS about them
> > in _OSI method. Currently Linux doesn't notify any, which might make such
> > features not work because BIOS doesn't know about them.
> > 
> 
> This is a bit vague.  Are any machines actually fixed or improved by
> this change?  Is so, can we please see a full description of the
> behaviour change?
I haven't a system which needs the fix. Jarosz Sebastian has a system
which needs this to make ACPI processor aggregator device work.

Thanks,
Shaohua

---------------------------------------------------------------------
Intel Technology Poland sp. z o.o.
z siedziba w Gdansku
ul. Slowackiego 173
80-298 Gdansk

Sad Rejonowy Gdansk Polnoc w Gdansku, 
VII Wydzial Gospodarczy Krajowego Rejestru Sadowego, 
numer KRS 101882

NIP 957-07-52-316
Kapital zakladowy 200.000 zl

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.