From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Keith Packard <keithp@keithp.com>
Cc: intel-gfx@lists.freedesktop.org, linux-acpi@vger.kernel.org
Subject: Re: [PATCH] i915: Fix opregion notifications
Date: Tue, 12 Jul 2011 23:30:01 +0100 [thread overview]
Message-ID: <20110712223000.GA16307@srcf.ucam.org> (raw)
In-Reply-To: <yunhb6rjg48.fsf@aiko.keithp.com>
On Tue, Jul 12, 2011 at 03:20:23PM -0700, Keith Packard wrote:
> Seriously? It's some kind of magic non-switch switch event? And you can
> tell by checking magic bits within the event?
The Intel drivers on Windows appear to have used 0x80 as a generic
"Something's chanegd" notification, overloading it for docking, lid
state change and display switch press. As a result of that right now
we're sending a display switch event whenever one of these occurs. Less
than ideal. Opregion gives us a magic field in shared OS/firmware memory
that can be used to distinguish between these events.
> How can I test this and know if it works?
Tested on a Thinkpad X200. Make sure suspend is disabled, then close the
lid. Open it again. The ACPI video input device will send a display
switch event. Add this patch and repeat and the event will vanish. The
display switch itself will still generate an event.
I'll send v2 now.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2011-07-12 22:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-12 21:51 [PATCH] i915: Fix opregion notifications Matthew Garrett
2011-07-12 22:20 ` Keith Packard
2011-07-12 22:30 ` Matthew Garrett [this message]
2011-07-12 22:30 ` [PATCH V2] " Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110712223000.GA16307@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=keithp@keithp.com \
--cc=linux-acpi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox