From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vasiliy Kulikov Subject: Re: [PATCH] acpi: constify ops structs Date: Fri, 15 Jul 2011 10:35:26 +0400 Message-ID: <20110715063526.GB3166@albatros> References: <20110625170752.GA10458@albatros> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20110625170752.GA10458@albatros> Sender: linux-ide-owner@vger.kernel.org To: Len Brown Cc: kernel-hardening@lists.openwall.com, Shaohua Li , Zhang Rui , Jeff Garzik , Jesse Barnes , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org, linux-pci@vger.kernel.org List-Id: linux-acpi@vger.kernel.org Hi Len, On Sat, Jun 25, 2011 at 21:07 +0400, Vasiliy Kulikov wrote: > Structs battery_file, acpi_dock_ops, file_operations, > thermal_cooling_device_ops, thermal_zone_device_ops, kernel_param_ops > are not changed in runtime. It is safe to make them const. > register_hotplug_dock_device() was altered to take const "ops" argument > to respect acpi_dock_ops' const notion. > > Signed-off-by: Vasiliy Kulikov > --- Any problems with the patch? > Len, I think it can be applied as a single patch to acpi tree as the > only non-acpi thing is acpi_dock_ops in ata/ and pci/, which is really > trivial. Thanks, -- Vasiliy Kulikov http://www.openwall.com - bringing security into open computing environments