From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ingo Molnar Subject: Re: [PATCH 2/2] x86: Enable monitor/mwait on Intel if BIOS hasn't already Date: Fri, 5 Aug 2011 11:43:19 +0200 Message-ID: <20110805094319.GA2420@elte.hu> References: <5bec80947da3fb72f2f18fbe6d924a69f83fbed9.1312386029.git.luto@mit.edu> <20110804194117.GA5265@srcf.ucam.org> <20110804215619.GA7101@srcf.ucam.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mx2.mail.elte.hu ([157.181.151.9]:38736 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750976Ab1HEJo1 (ORCPT ); Fri, 5 Aug 2011 05:44:27 -0400 Content-Disposition: inline In-Reply-To: <20110804215619.GA7101@srcf.ucam.org> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Matthew Garrett Cc: Len Brown , Andrew Lutomirski , x86@kernel.org, linux-kernel@vger.kernel.org, Fenghua Yu , linux-acpi@vger.kernel.org * Matthew Garrett wrote: > On Thu, Aug 04, 2011 at 05:54:04PM -0400, Len Brown wrote: > > > We can't trust BIOS authors to get things right. Where we can reliably > > > fix up things that are broken, we should do so. > > > > How about if we can get a BIOS fix for this brand new system, > > then we shall not clutter the kernel with a workaround, otherwise > > we shall. > > It's a pretty good rule of thumb that if a BIOS bug is present in > one BIOS it's present in others, but the users will just never > notice. Yes. There's no harm really from working around a BIOS bug and warning about it - when the BIOS gets fixed the warning message will go away. Btw., few people risk upgrading their BIOSen on already purchased hardware. I almost never do it, i only do it if it's impossible to continue with a current BIOS. Thanks, Ingo