From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: "Cihula, Joseph" <joseph.cihula@intel.com>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>,
"Brown, Len" <len.brown@intel.com>,
"Tian, Kevin" <kevin.tian@intel.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
"hpa@zytor.com" <hpa@zytor.com>,
"x86@kernel.org" <x86@kernel.org>,
Fitzhardinge <jeremy.fitzhardinge@citrix.com>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"tboot-devel@lists.sourceforge.net"
<tboot-devel@lists.sourceforge.net>,
"liang.tang@oracle.com" <liang.tang@oracle.com>,
"Yu, Ke" <ke.yu@intel.com>,
"linux-pm@lists.linux-foundation.org"
<linux-pm@lists.linux-foundation.org>,
"keir@xen.org" <keir@xen.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"Wei, Gang" <gang.wei@intel.com>
Subject: Re: [Xen-devel] RE: [PATCH 5/7] xen/acpi: Domain0 acpi parser related platform hypercall
Date: Wed, 7 Sep 2011 15:06:59 -0400 [thread overview]
Message-ID: <20110907190659.GH7074@dumpdata.com> (raw)
In-Reply-To: <9F57BF860713DF4BA3EFA4F8C6DFEDAC16F40F0B@ORSMSX101.amr.corp.intel.com>
> > >> +#define XENPF_enter_acpi_sleep 51
> > >> +struct xenpf_enter_acpi_sleep {
> > >> + /* IN variables */
> > >> + uint16_t pm1a_cnt_val; /* PM1a control value. */
> > >> + uint16_t pm1b_cnt_val; /* PM1b control value. */
> > > These are uint32_t in native Linux--why truncate in the API and not at use?
> >
> > Does ACPI define them as 32 or 16 bit?
>
> The spec indicates that the length is variable and could be up to 32 bits (AFAICT). And Linux uses 32b, which your other patch is truncating for this call.
Yikes! Well, looks like we need to fix the Xen ABI too. Lets get that fixed
and also address all the other comments (thanks for looking at it) you pointed
out.
next prev parent reply other threads:[~2011-09-07 19:11 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-31 18:31 [RFC PATCH v1] ACPI S3 to work under Xen Konrad Rzeszutek Wilk
2011-08-31 18:31 ` [PATCH 1/7] x86: Expand the x86_msi_ops to have a restore MSIs Konrad Rzeszutek Wilk
2011-08-31 18:31 ` [PATCH 2/7] x86, acpi, tboot: Have a ACPI sleep override instead of calling tboot_sleep Konrad Rzeszutek Wilk
2011-09-07 4:20 ` Cihula, Joseph
2011-09-07 17:27 ` [Xen-devel] " Jeremy Fitzhardinge
2011-09-07 17:55 ` Cihula, Joseph
2011-08-31 18:31 ` [PATCH 3/7] x86/acpi/sleep: Provide registration for acpi_suspend_lowlevel Konrad Rzeszutek Wilk
2011-08-31 18:31 ` [PATCH 4/7] xen: Utilize the restore_msi_irqs hook Konrad Rzeszutek Wilk
2011-08-31 18:31 ` [PATCH 5/7] xen/acpi: Domain0 acpi parser related platform hypercall Konrad Rzeszutek Wilk
2011-09-07 5:50 ` Cihula, Joseph
2011-09-07 17:29 ` [Xen-devel] " Jeremy Fitzhardinge
2011-09-07 17:43 ` Cihula, Joseph
2011-09-07 19:06 ` Konrad Rzeszutek Wilk [this message]
2011-09-08 13:38 ` Konrad Rzeszutek Wilk
2011-09-22 12:51 ` Konrad Rzeszutek Wilk
2011-09-21 19:29 ` Konrad Rzeszutek Wilk
2011-09-21 22:42 ` Jeremy Fitzhardinge
2011-08-31 18:31 ` [PATCH 6/7] xen/acpi/sleep: Enable ACPI sleep via the __acpi_override_sleep Konrad Rzeszutek Wilk
2011-09-07 4:36 ` Cihula, Joseph
2011-08-31 18:31 ` [PATCH 7/7] xen/acpi/sleep: Register to the acpi_suspend_lowlevel a callback Konrad Rzeszutek Wilk
2011-09-01 6:58 ` [RFC PATCH v1] ACPI S3 to work under Xen Tian, Kevin
2011-09-02 11:52 ` [Xen-devel] " Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110907190659.GH7074@dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=gang.wei@intel.com \
--cc=hpa@zytor.com \
--cc=jeremy.fitzhardinge@citrix.com \
--cc=jeremy@goop.org \
--cc=joseph.cihula@intel.com \
--cc=ke.yu@intel.com \
--cc=keir@xen.org \
--cc=kevin.tian@intel.com \
--cc=len.brown@intel.com \
--cc=liang.tang@oracle.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=tboot-devel@lists.sourceforge.net \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).