From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Sarah Sharp <sarah.a.sharp@linux.intel.com>
Cc: linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
Matthew Garrett <mjg59@srcf.ucam.org>
Subject: Re: PME via interrupt or SCI mechanism?
Date: Thu, 29 Sep 2011 23:28:45 +0200 [thread overview]
Message-ID: <201109292328.45375.rjw@sisk.pl> (raw)
In-Reply-To: <20110929204440.GA6043@xanatos>
On Thursday, September 29, 2011, Sarah Sharp wrote:
> On Thu, Sep 29, 2011 at 09:39:56PM +0200, Rafael J. Wysocki wrote:
> > On Thursday, September 29, 2011, Sarah Sharp wrote:
> > > On Thu, Sep 29, 2011 at 12:21:28AM +0200, Rafael J. Wysocki wrote:
> > Please try the appended patch and check if you see the "Notification error
> > for GPE" message (please keep your previous debug patches applied).
>
> Do I need to have the ACPI debug_level or debug_layer set to anything in
> particular to see this message?
No, I don't think so, but just in case please try the patch below instead
of the previous one.
Thanks,
Rafael
---
drivers/acpi/acpica/evgpe.c | 14 +++++++++++++-
1 file changed, 13 insertions(+), 1 deletion(-)
Index: linux/drivers/acpi/acpica/evgpe.c
===================================================================
--- linux.orig/drivers/acpi/acpica/evgpe.c
+++ linux/drivers/acpi/acpica/evgpe.c
@@ -521,12 +521,24 @@ static void ACPI_SYSTEM_XFACE acpi_ev_as
status = acpi_ev_queue_notify_request(
local_gpe_event_info->dispatch.device.node,
ACPI_NOTIFY_DEVICE_WAKE);
+ if (ACPI_FAILURE(status))
+ pr_err("Notification error for GPE 0x%X",
+ local_gpe_event_info->gpe_number);
+ else
+ pr_info("Notification queued up for GPE 0x%X",
+ local_gpe_event_info->gpe_number);
notify_object = local_gpe_event_info->dispatch.device.next;
- while (ACPI_SUCCESS(status) && notify_object) {
+ while (notify_object) {
status = acpi_ev_queue_notify_request(
notify_object->node,
ACPI_NOTIFY_DEVICE_WAKE);
+ if (ACPI_FAILURE(status))
+ pr_err("Notification error for GPE 0x%X",
+ local_gpe_event_info->gpe_number);
+ else
+ pr_info("Notification queued up for GPE 0x%X",
+ local_gpe_event_info->gpe_number);
notify_object = notify_object->next;
}
next prev parent reply other threads:[~2011-09-29 21:26 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-12 17:10 PME via interrupt or SCI mechanism? Sarah Sharp
2011-09-19 21:43 ` Rafael J. Wysocki
[not found] ` <20110922183201.GA4659@xanatos>
2011-09-25 14:53 ` Rafael J. Wysocki
2011-09-26 22:20 ` Rafael J. Wysocki
2011-09-26 23:48 ` Sarah Sharp
2011-09-27 11:21 ` Luming Yu
2011-09-27 20:32 ` Rafael J. Wysocki
2011-09-28 3:10 ` Luming Yu
2011-09-27 20:54 ` Rafael J. Wysocki
2011-09-27 23:52 ` Sarah Sharp
2011-09-28 22:21 ` Rafael J. Wysocki
2011-09-29 1:40 ` Matthew Garrett
2011-09-29 9:05 ` Rafael J. Wysocki
2011-09-29 18:23 ` Sarah Sharp
2011-09-29 19:39 ` Rafael J. Wysocki
2011-09-29 20:44 ` Sarah Sharp
2011-09-29 21:28 ` Rafael J. Wysocki [this message]
2011-09-29 21:38 ` Rafael J. Wysocki
2011-09-29 21:51 ` Rafael J. Wysocki
[not found] ` <20110929225700.GA6207@xanatos>
2011-09-30 16:40 ` Rafael J. Wysocki
2011-09-30 20:21 ` Rafael J. Wysocki
2011-10-01 0:30 ` Sarah Sharp
2011-10-01 20:29 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201109292328.45375.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=sarah.a.sharp@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox