From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Prarit Bhargava <prarit@redhat.com>
Cc: linux-pci@vger.kernel.org, mjg@redhat.com, bhelgaas@google.com,
linux-acpi@vger.kernel.org
Subject: Re: [PATCH] acpiphp: Prevent deadlock on PCI-to-PCI bridge remove
Date: Fri, 14 Oct 2011 09:07:35 -0700 [thread overview]
Message-ID: <20111014090735.44b38707@jbarnes-desktop> (raw)
In-Reply-To: <1317253253-28259-1-git-send-email-prarit@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1210 bytes --]
On Wed, 28 Sep 2011 19:40:53 -0400
Prarit Bhargava <prarit@redhat.com> wrote:
> I originally submitted a patch to workaround this by pushing all Ejection
> Requests and Device Checks onto the kacpi_hotplug queue.
>
> http://marc.info/?l=linux-acpi&m=131678270930105&w=2
>
> The patch is still insufficient in that Bus Checks also need to be added.
>
> Rather than add all events, including non-PCI-hotplug events, to the
> hotplug queue, mjg suggested that a better approach would be to modify
> the acpiphp driver so only acpiphp events would be added to the
> kacpi_hotplug queue.
>
> It's a longer patch, but at least we maintain the benefit of having separate
> queues in ACPI. This, of course, is still only a workaround the problem.
> As Bjorn and mjg pointed out, we have to refactor a lot of this code to do
> the right thing but at this point it is a better to have this code working.
>
> Jesse -- Unless there are any objections from the ACPI guys, I think this
> patch should be pushed through linux-pci now since 95% of the changes are
> contained within drivers/pci/hotplug.
Applied to linux-next, thanks.
--
Jesse Barnes, Intel Open Source Technology Center
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2011-10-14 16:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-28 23:40 [PATCH] acpiphp: Prevent deadlock on PCI-to-PCI bridge remove Prarit Bhargava
2011-10-14 16:07 ` Jesse Barnes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111014090735.44b38707@jbarnes-desktop \
--to=jbarnes@virtuousgeek.org \
--cc=bhelgaas@google.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mjg@redhat.com \
--cc=prarit@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox