From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
LKML <linux-kernel@vger.kernel.org>,
Linux PM mailing list <linux-pm@lists.linux-foundation.org>,
ACPI Devel Mailing List <linux-acpi@vger.kernel.org>,
linux-pci@vger.kernel.org
Subject: Re: [PATCH] PCI / PM: Remove unnecessary error variable from acpi_dev_run_wake()
Date: Fri, 14 Oct 2011 09:07:58 -0700 [thread overview]
Message-ID: <20111014090758.23aabe2d@jbarnes-desktop> (raw)
In-Reply-To: <201109282144.36766.rjw@sisk.pl>
[-- Attachment #1: Type: text/plain, Size: 782 bytes --]
On Wed, 28 Sep 2011 21:44:36 +0200
"Rafael J. Wysocki" <rjw@sisk.pl> wrote:
> ---
> From: Rafael J. Wysocki <rjw@sisk.pl>
> Subject: PCI / PM: Return correct result from acpi_dev_run_wake()
>
> The result returned by acpi_dev_run_wake() is always either -EINVAL
> or -ENODEV, while obviously it should return 0 on success. The
> problem is that the leftover error variable, that's not really used
> in the function, is initialized with -ENODEV and then returned
> without modification.
>
> To fix this issue remove the error variable from acpi_dev_run_wake()
> and make the function return 0 on success as appropriate.
>
> Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
Applied to linux-next, thanks.
--
Jesse Barnes, Intel Open Source Technology Center
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2011-10-14 16:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-27 22:01 [PATCH] PCI / PM: Remove unnecessary error variable from acpi_dev_run_wake() Rafael J. Wysocki
2011-09-28 19:27 ` Bjorn Helgaas
2011-09-28 19:44 ` Rafael J. Wysocki
2011-10-14 16:07 ` Jesse Barnes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111014090758.23aabe2d@jbarnes-desktop \
--to=jbarnes@virtuousgeek.org \
--cc=bhelgaas@google.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox