From mboxrd@z Thu Jan  1 00:00:00 1970
From: Seth Forshee <seth.forshee@canonical.com>
Subject: Re: [PATCH v2 1/4] ACPI: EC: Add ec_get_handle()
Date: Thu, 5 Jan 2012 13:34:36 -0600
Message-ID: <20120105193436.GC25386@ubuntu-macmini>
References: <1325617358-8286-1-git-send-email-seth.forshee@canonical.com>
 <1325617358-8286-2-git-send-email-seth.forshee@canonical.com>
 <CAPbh3ruqMQ8UFSehm7vX5i8YWzRFwF5=TX_f4n4dVkvmQa9Njw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <platform-driver-x86-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <CAPbh3ruqMQ8UFSehm7vX5i8YWzRFwF5=TX_f4n4dVkvmQa9Njw@mail.gmail.com>
Sender: platform-driver-x86-owner@vger.kernel.org
To: Konrad Rzeszutek Wilk <konrad@darnok.org>
Cc: Thomas Renninger <trenn@suse.de>, Matthew Garrett <mjg@redhat.com>, linux-acpi@vger.kernel.org, Azael Avalos <coproscefalo@gmail.com>, platform-driver-x86@vger.kernel.org, Len Brown <lenb@kernel.org>, linux-kernel@vger.kernel.org
List-Id: linux-acpi@vger.kernel.org

On Thu, Jan 05, 2012 at 01:27:08PM -0500, Konrad Rzeszutek Wilk wrote:
> 8
> On Jan 3, 2012 2:05 PM, "Seth Forshee" <seth.forshee@canonical.com> wrote:
> >
> > toshiba_acpi needs to execute an AML method within the EC namespace
> > to make hotkeys work on some platforms. Provide an interface to
> > allow it to easily get a handle to the EC namespace for this purpose.
> >
> > Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
> > ---
> >  drivers/acpi/ec.c    |   10 ++++++++++
> >  include/linux/acpi.h |    1 +
> >  2 files changed, 11 insertions(+), 0 deletions(-)
> >
> > diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
> > index b19a18d..e37615f 100644
> > --- a/drivers/acpi/ec.c
> > +++ b/drivers/acpi/ec.c
> > @@ -445,6 +445,16 @@ int ec_transaction(u8 command,
> >
> >  EXPORT_SYMBOL(ec_transaction);
> >
> > +/* Get the handle to the EC device */
> > +acpi_handle ec_get_handle(void)
> > +{
> > +       if (!first_ec)
> > +               return NULL;
> > +       return first_ec->handle;
> > +}
> > +
> > +EXPORT_SYMBOL(ec_get_handle);
> 
> shouldn't this be _GPL?

I don't know. All the other ec_* interfaces are EXPORT_SYMBOL, so I did
likewise. I'm happy to change it if _GPL is what ought to be used here.