From: Seth Forshee <seth.forshee@canonical.com>
To: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: Len Brown <lenb@kernel.org>,
Azael Avalos <coproscefalo@gmail.com>,
Thomas Renninger <trenn@suse.de>,
platform-driver-x86@vger.kernel.org, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/4] toshiba_acpi: Add blacklist for models with hotkey problems
Date: Thu, 5 Jan 2012 14:04:32 -0600 [thread overview]
Message-ID: <20120105200432.GE25386@ubuntu-macmini> (raw)
In-Reply-To: <20120105193431.GA26097@srcf.ucam.org>
On Thu, Jan 05, 2012 at 07:34:31PM +0000, Matthew Garrett wrote:
> On Thu, Jan 05, 2012 at 01:32:28PM -0600, Seth Forshee wrote:
>
> > Also a side note of interest: The machines that suffer from this all
> > also have a WMI interface with code to support hotkeys, and that code
> > shouldn't suffer from this problem. Unfortunately these models are the
> > only ones I've seen with this WMI interface, and the code to generate
> > the hotkey events isn't executed if the OS reports itself as Vista or
> > newer.
>
> In that case, can you check for the presence of the WMI interface and
> then refuse to bind? That's seem far simpler than adding an unknown
> number of systems to the blacklist.
Hmm, I suppose I could look for the specific WMI event guid, although
the relationship between the two seems tenuous at best. It would make
sense to me if we were refusing to bind because there was a better
interface available, but Toshiba is obviously treating hotkeys on the
WMI interface as legacy since it's disabled in the BIOS for Vista or
later. INFO seems to be the preferred interface.
next prev parent reply other threads:[~2012-01-05 20:04 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-03 19:02 [PATCH v2 0/4] toshiba_acpi: Expanded hotkey support Seth Forshee
2012-01-03 19:02 ` [PATCH v2 1/4] ACPI: EC: Add ec_get_handle() Seth Forshee
2012-01-05 18:22 ` Matthew Garrett
[not found] ` <CAPbh3ruqMQ8UFSehm7vX5i8YWzRFwF5=TX_f4n4dVkvmQa9Njw@mail.gmail.com>
2012-01-05 19:34 ` Seth Forshee
2012-01-07 20:55 ` Konrad Rzeszutek Wilk
2012-01-07 21:26 ` Matthew Garrett
2012-01-03 19:02 ` [PATCH v2 2/4] toshiba_acpi: Support alternate hotkey interfaces Seth Forshee
2012-01-05 18:25 ` Matthew Garrett
2012-01-05 19:43 ` Seth Forshee
2012-01-05 19:47 ` Matthew Garrett
2012-01-03 19:02 ` [PATCH v2 3/4] toshiba_acpi: Support additional hotkey scancodes Seth Forshee
2012-01-03 19:02 ` [PATCH v2 4/4] toshiba_acpi: Add blacklist for models with hotkey problems Seth Forshee
2012-01-05 18:26 ` Matthew Garrett
2012-01-05 19:32 ` Seth Forshee
2012-01-05 19:34 ` Matthew Garrett
2012-01-05 20:04 ` Seth Forshee [this message]
2012-01-05 20:09 ` Matthew Garrett
2012-01-05 20:24 ` Seth Forshee
2012-01-05 20:46 ` Moore, Robert
2012-01-05 20:58 ` Seth Forshee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120105200432.GE25386@ubuntu-macmini \
--to=seth.forshee@canonical.com \
--cc=coproscefalo@gmail.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=trenn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).