linux-acpi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Matthieu CASTET <castet.matthieu@free.fr>
Cc: linux-acpi@vger.kernel.org, hpa@zytor.com,
	linux-kernel@vger.kernel.org, rjw@sisk.pl
Subject: Re: [PATCH 1/2] merge 32 and 64 realmode wakeup code
Date: Fri, 13 Jan 2012 19:01:22 +0100	[thread overview]
Message-ID: <20120113180121.GA9433@atrey.karlin.mff.cuni.cz> (raw)
In-Reply-To: <1324066385-8491-1-git-send-email-castet.matthieu@free.fr>

> - this mean less ifdef in code
> - we could remove now unused field in wakeup_header (pmode_*)
> 
> Signed-off-by: Matthieu CASTET <castet.matthieu@free.fr>

Looks good... was it tested on both 32 and 64 bit?

> -	/* This really couldn't... */
> -	movl	pmode_cr0, %eax
> -	movl	%eax, %cr0
> -	jmp	pmode_return

How was this handled?
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

  parent reply	other threads:[~2012-01-13 18:01 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-16 20:13 [PATCH 1/2] merge 32 and 64 realmode wakeup code Matthieu CASTET
2011-12-16 20:13 ` [PATCH 2/2] clean acpi wakeup code after merge Matthieu CASTET
2012-01-13 18:01 ` Pavel Machek [this message]
  -- strict thread matches above, loose matches on Subject: below --
2011-07-02 17:43 [PATCH 1/2] merge 32 and 64 realmode wakeup code Matthieu CASTET
2011-07-02 22:31 ` H. Peter Anvin
2011-07-03  6:50   ` Rafael J. Wysocki
2011-07-03 20:52     ` matthieu castet
2011-07-03 21:19       ` H. Peter Anvin
2011-03-13 22:03 matthieu castet
2011-03-13 22:31 ` Rafael J. Wysocki
2011-03-13 23:06   ` H. Peter Anvin
2011-03-15 19:31   ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120113180121.GA9433@atrey.karlin.mff.cuni.cz \
    --to=pavel@ucw.cz \
    --cc=castet.matthieu@free.fr \
    --cc=hpa@zytor.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rjw@sisk.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).