From: Thomas Renninger <trenn@suse.de>
To: akpm@linux-foundation.org
Cc: lenb@kernel.org, len.brown@intel.com, linux-acpi@vger.kernel.org,
shaohua.li@intel.com
Subject: Re: [patch 1/3] intel_idle: fix API misuse
Date: Tue, 17 Jan 2012 11:37:58 +0100 [thread overview]
Message-ID: <201201171137.58857.trenn@suse.de> (raw)
In-Reply-To: <20120110234819.7F484100270@wpzn3.hot.corp.google.com>
On Wednesday, January 11, 2012 12:48:19 AM akpm@linux-foundation.org wrote:
> From: Shaohua Li <shaohua.li@intel.com>
> Subject: intel_idle: fix API misuse
This one looks worth adding:
CC: stable@vger.kernel.org
> smp_call_function() only lets all other CPUs execute a specific function,
> while we expect all CPUs do in intel_idle. Without the fix, we could have
> one cpu which has auto_demotion enabled or has no boradcast timer setup.
> Usually we don't see impact because auto demotion just harms power and the
> intel_idle init is called in CPU 0, where boradcast timer delivers
> interrupt, but this still could be a problem.
>
> Signed-off-by: Shaohua Li <shaohua.li@intel.com>
> Cc: Len Brown <lenb@kernel.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
CC: stable@vger.kernel.org
Thomas
next prev parent reply other threads:[~2012-01-17 10:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-10 23:48 [patch 1/3] intel_idle: fix API misuse akpm
2012-01-17 10:37 ` Thomas Renninger [this message]
2012-01-18 0:21 ` Andrew Morton
2012-01-18 0:55 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201201171137.58857.trenn@suse.de \
--to=trenn@suse.de \
--cc=akpm@linux-foundation.org \
--cc=len.brown@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox