From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [patch 1/3] intel_idle: fix API misuse Date: Tue, 17 Jan 2012 16:21:43 -0800 Message-ID: <20120117162143.28192549.akpm@linux-foundation.org> References: <20120110234819.7F484100270@wpzn3.hot.corp.google.com> <201201171137.58857.trenn@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from mail.linuxfoundation.org ([140.211.169.12]:43882 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755789Ab2ARAVo (ORCPT ); Tue, 17 Jan 2012 19:21:44 -0500 In-Reply-To: <201201171137.58857.trenn@suse.de> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Thomas Renninger Cc: lenb@kernel.org, len.brown@intel.com, linux-acpi@vger.kernel.org, shaohua.li@intel.com, stable@vger.kernel.org (let's cc stable on this thread then!) On Tue, 17 Jan 2012 11:37:58 +0100 Thomas Renninger wrote: > On Wednesday, January 11, 2012 12:48:19 AM akpm@linux-foundation.org wrote: > > From: Shaohua Li > > Subject: intel_idle: fix API misuse > > This one looks worth adding: > CC: stable@vger.kernel.org > > > > smp_call_function() only lets all other CPUs execute a specific function, > > while we expect all CPUs do in intel_idle. Without the fix, we could have > > one cpu which has auto_demotion enabled or has no boradcast timer setup. > > Usually we don't see impact because auto demotion just harms power and the > > intel_idle init is called in CPU 0, where boradcast timer delivers > > interrupt, but this still could be a problem. > > > > Signed-off-by: Shaohua Li > > Cc: Len Brown > > Signed-off-by: Andrew Morton > CC: stable@vger.kernel.org > OK. I think Len is processing these patches at present. So stable@vger.kernel.org will see when I've dropped my copy of the patch, but the version which goes into mainline might be missing the stable tag. Hopefully Greg is awake enough to sort out that cryptic messaging!