From: Matthew Garrett <mjg@redhat.com>
To: Amit Daniel Kachhap <amit.kachhap@linaro.org>
Cc: linux-pm@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
lenb@kernel.org, rui.zhang@intel.com,
linaro-dev@lists.linaro.org, patches@linaro.org
Subject: Re: [RFC PATCH 2/2] thermal: Add generic cpu cooling implementation
Date: Wed, 1 Feb 2012 14:57:07 +0000 [thread overview]
Message-ID: <20120201145707.GD30184@srcf.ucam.org> (raw)
In-Reply-To: <1323789196-4942-3-git-send-email-amit.kachhap@linaro.org>
On Tue, Dec 13, 2011 at 08:43:16PM +0530, Amit Daniel Kachhap wrote:
> This patch adds support for generic cpu thermal cooling low level
> implementations using frequency scaling and cpuhotplugg currently.
We've been over this kind of thing in the past. cpu hotplug is a
relatively expensive operation, so people have previously been
enthusiastic about using the scheduler to simply avoid running anything
on CPUs if they're overheating. Has any general consensus been reached
on this?
I'm also not entirely thrilled at now having two ways to manage the cpu
through the thermal layer. ACPI already plugs in via the passive trip
points. If we're going to do this then I'd like to see the ACPI code
merged in with the generic cpu cooling code.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2012-02-01 14:57 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-13 15:13 [RFC PATCH 0/2] thermal: Add generic cpu cooling devices according to thermal framework Amit Daniel Kachhap
2011-12-13 15:13 ` [RFC PATCH 1/2] thermal: Add a new trip type to use cooling device instance number Amit Daniel Kachhap
2011-12-20 12:37 ` [linux-pm] " Vincent Guittot
2011-12-21 5:08 ` Amit Kachhap
2011-12-21 5:11 ` [linux-pm] " Amit Kachhap
2012-01-11 8:12 ` Rob Lee
2012-01-13 4:02 ` Amit Kachhap
2012-02-01 14:49 ` Matthew Garrett
2012-02-02 7:14 ` Amit Kachhap
2012-02-02 7:16 ` Amit Kachhap
2011-12-13 15:13 ` [RFC PATCH 2/2] thermal: Add generic cpu cooling implementation Amit Daniel Kachhap
[not found] ` <1323789196-4942-3-git-send-email-amit.kachhap-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2012-01-11 8:02 ` Rob Lee
2012-01-13 3:50 ` Amit Kachhap
2012-01-16 14:13 ` Rob Lee
2012-02-01 14:57 ` Matthew Garrett [this message]
2012-02-02 9:16 ` Amit Kachhap
2012-02-07 8:25 ` [linux-pm] " Eduardo Valentin
2012-02-07 18:21 ` Amit Kachhap
2012-02-07 19:34 ` Eduardo Valentin
2012-01-19 9:17 ` [RFC PATCH 0/2] thermal: Add generic cpu cooling devices according to thermal framework Amit Kachhap
2012-02-03 7:12 ` Zhang Rui
2012-02-03 12:13 ` Amit Kachhap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120201145707.GD30184@srcf.ucam.org \
--to=mjg@redhat.com \
--cc=amit.kachhap@linaro.org \
--cc=lenb@kernel.org \
--cc=linaro-dev@lists.linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=patches@linaro.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).