From: Andi Kleen <andi@firstfloor.org>
To: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: Andi Kleen <andi@firstfloor.org>,
lenb@kernel.org, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org, Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 4/5] ACPI: Do cpufreq clamping for throttling per package v2
Date: Mon, 6 Feb 2012 18:59:18 +0100 [thread overview]
Message-ID: <20120206175918.GN11715@one.firstfloor.org> (raw)
In-Reply-To: <20120206163106.GB32061@srcf.ucam.org>
On Mon, Feb 06, 2012 at 04:31:06PM +0000, Matthew Garrett wrote:
> On Mon, Feb 06, 2012 at 08:17:11AM -0800, Andi Kleen wrote:
> > +#define reduction_pctg(cpu) \
> > + per_cpu(cpufreq_thermal_reduction_pctg, phys_package_first_cpu(cpu))
>
> I don't like using percentages here - we end up with the potential for
The code was using percentages before, i merely moved the accounting
to be per package. I don't disagree with changing them, but it
should be probably a separate patch.
-Andi
next prev parent reply other threads:[~2012-02-06 17:59 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-06 16:17 Updated throttling fix patchkit Andi Kleen
2012-02-06 16:17 ` [PATCH 1/5] ACPI: ec: Do request_region outside WARN() Andi Kleen
2012-03-22 6:08 ` Len Brown
2012-02-06 16:17 ` [PATCH 2/5] ACPI: Make ACPI interrupt threaded Andi Kleen
2012-02-06 16:17 ` [PATCH 4/5] ACPI: Do cpufreq clamping for throttling per package v2 Andi Kleen
2012-02-06 16:31 ` Matthew Garrett
2012-02-06 17:59 ` Andi Kleen [this message]
2012-02-13 23:30 ` Len Brown
2012-02-14 0:17 ` Matthew Garrett
2012-03-22 6:13 ` Len Brown
2012-03-30 10:05 ` Len Brown
2012-03-30 11:46 ` Matthew Garrett
2012-03-30 12:00 ` Len Brown
2012-02-06 16:17 ` [PATCH 5/5] Disable MCP limit exceeded messages from Intel IPS driver Andi Kleen
2012-02-07 19:45 ` Jesse Barnes
2012-03-22 6:25 ` Len Brown
[not found] ` <1328545032-21373-4-git-send-email-andi@firstfloor.org>
2012-02-06 16:27 ` [PATCH 3/5] ACPI: EC: Add a limited number of repeats after false EC interrupts Matthew Garrett
2012-02-06 18:01 ` Andi Kleen
2012-02-06 16:31 ` Updated throttling fix patchkit Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120206175918.GN11715@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=ak@linux.intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).