From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: shpc with acpi=off? Date: Thu, 16 Feb 2012 17:04:22 +0200 Message-ID: <20120216150421.GA26167@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline Sender: linux-pci-owner@vger.kernel.org To: jbarnes@virtuousgeek.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, lenb@kernel.org, linux-acpi@vger.kernel.org List-Id: linux-acpi@vger.kernel.org I have a box where shpc works fine with acpi, as well as when acpi is not built into kernel, but fails with acpi=off Some debugging seems to indicate that acpi_get_hp_hw_control_from_firmware fails with acpi=off. Is this a bug or is there a reason to prevent shpc from working in this setup? Do we even care about acpi=off? Assuming we want to make acpi_get_hp_hw_control_from_firmware succeed with acpi=off, what is the best way to do this? Check acpi_pci_disabled? Thoughts? -- MST