From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Lin Ming <ming.m.lin@intel.com>
Cc: Len Brown <lenb@kernel.og>,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
Zhang Rui <rui.zhang@intel.com>,
Huang Ying <huang.ying.caritas@gmail.com>,
Aaron Lu <aaron.lu@amd.com>
Subject: Re: [PATCH 1/6] ACPI: D3cold state is always valid
Date: Tue, 17 Apr 2012 22:29:18 +0200 [thread overview]
Message-ID: <201204172229.18203.rjw@sisk.pl> (raw)
In-Reply-To: <1334641676-14566-2-git-send-email-ming.m.lin@intel.com>
On Tuesday, April 17, 2012, Lin Ming wrote:
> ACPI_STATE_D3 actually means ACPI D3hot which is not always valid.
> Instead, ACPI D3cold is always valid.
>
> Signed-off-by: Lin Ming <ming.m.lin@intel.com>
Can you just introduce ACPI_STATE_D3_HOT and redefine D3_COLD so that
it's the same as D3, as I said?
Rafael
> ---
> drivers/acpi/scan.c | 11 ++---------
> 1 files changed, 2 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c
> index 767e2dc..fb56388 100644
> --- a/drivers/acpi/scan.c
> +++ b/drivers/acpi/scan.c
> @@ -884,13 +884,6 @@ static int acpi_bus_get_power_flags(struct acpi_device *device)
> acpi_bus_add_power_resource(ps->resources.handles[j]);
> }
>
> - /* The exist of _PR3 indicates D3Cold support */
> - if (i == ACPI_STATE_D3) {
> - status = acpi_get_handle(device->handle, object_name, &handle);
> - if (ACPI_SUCCESS(status))
> - device->power.states[ACPI_STATE_D3_COLD].flags.valid = 1;
> - }
> -
> /* Evaluate "_PSx" to see if we can do explicit sets */
> object_name[2] = 'S';
> status = acpi_get_handle(device->handle, object_name, &handle);
> @@ -908,8 +901,8 @@ static int acpi_bus_get_power_flags(struct acpi_device *device)
> /* Set defaults for D0 and D3 states (always valid) */
> device->power.states[ACPI_STATE_D0].flags.valid = 1;
> device->power.states[ACPI_STATE_D0].power = 100;
> - device->power.states[ACPI_STATE_D3].flags.valid = 1;
> - device->power.states[ACPI_STATE_D3].power = 0;
> + device->power.states[ACPI_STATE_D3_COLD].flags.valid = 1;
> + device->power.states[ACPI_STATE_D3_COLD].power = 0;
>
> acpi_bus_init_power(device);
>
>
next prev parent reply other threads:[~2012-04-17 20:24 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-17 5:47 [PATCH 0/6]: ACPI D3 state cleanup Lin Ming
2012-04-17 5:47 ` [PATCH 1/6] ACPI: D3cold state is always valid Lin Ming
2012-04-17 6:03 ` huang ying
2012-04-18 21:13 ` Rafael J. Wysocki
2012-04-19 1:35 ` huang ying
2012-04-19 11:51 ` Rafael J. Wysocki
2012-04-19 15:23 ` Lin Ming
2012-04-19 20:39 ` Rafael J. Wysocki
2012-04-17 20:29 ` Rafael J. Wysocki [this message]
2012-04-18 2:15 ` Lin Ming
2012-04-18 2:32 ` Lin Ming
2012-04-18 9:09 ` Rafael J. Wysocki
2012-04-17 5:47 ` [PATCH 2/6] ACPI: Set D3cold state as default device sleep state Lin Ming
2012-04-17 5:47 ` [PATCH 3/6] ACPI: Set D3cold state as default inferred state Lin Ming
2012-04-17 5:47 ` [PATCH 4/6] ACPI: Fix power resource's device power state when it's off Lin Ming
2012-04-17 5:47 ` [PATCH 5/6] PCI/ACPI: Map PCI D3cold state to ACPI D3cold state Lin Ming
2012-04-17 5:47 ` [PATCH 6/6] ACPI: Rename ACPI_STATE_D3 to ACPI_STATE_D3_HOT Lin Ming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201204172229.18203.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=aaron.lu@amd.com \
--cc=huang.ying.caritas@gmail.com \
--cc=lenb@kernel.og \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.m.lin@intel.com \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).