From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rafael J. Wysocki" Subject: Re: [PATCH] ACPI: evaluate _PS3 when entering D3 Cold Date: Tue, 24 Apr 2012 23:15:00 +0200 Message-ID: <201204242315.00419.rjw@sisk.pl> References: <1333217910-29579-1-git-send-email-aaron.lu@amd.com> <20120424142457.GA5292@fedora> Mime-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: Received: from ogre.sisk.pl ([193.178.161.156]:34906 "EHLO ogre.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757708Ab2DXVKW (ORCPT ); Tue, 24 Apr 2012 17:10:22 -0400 In-Reply-To: <20120424142457.GA5292@fedora> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Aaron Lu Cc: Lin Ming , Len Brown , linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Zhang Rui , Andiry Xu , Alex He On Tuesday, April 24, 2012, Aaron Lu wrote: > On Tue, Apr 24, 2012 at 09:15:37PM +0800, Lin Ming wrote: > > >> > diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c > > >> > index 7417267..734d946 100644 > > >> > --- a/drivers/acpi/scan.c > > >> > +++ b/drivers/acpi/scan.c > > >> > @@ -908,6 +908,10 @@ static int acpi_bus_get_power_flags(struct acpi_device *device) > > >> > device->power.states[ACPI_STATE_D3].flags.valid = 1; > > >> > device->power.states[ACPI_STATE_D3].power = 0; > > >> > > > >> > + /* Also set D3cold's explicit flag when _PS3 exists */ > > >> > + if (device->power.states[ACPI_STATE_D3_HOT].flags.explicit_set) > > >> > + device->power.states[ACPI_STATE_D3].flags.explicit_set = 1; > > >> > > >> We should use ACPI_STATE_D3_COLD instead of ACPI_STATE_D3 to make thing > > >> clear. > > >> > > > Thanks for your suggestion. > > > > > > Well, considering all those ACPI_STATE_D3 used in tree, I don't think I > > > should use ACPI_STATE_D3_COLD here, especially the two lines above are > > > still using ACPI_STATE_D3. > > > > > > But if that is desired, we should probably change all the existing > > > ACPI_STATE_D3 macros to ACPI_STATE_D3_COLD to make things clear. > > > > > > Or we all use ACPI_STATE_D3, since it is defined as 4 and means D3 cold, > > > and people will learn this, won't they? > > > > > > What do you think? > > > > OK. > > > > But we may do more cleanup later. > > > > Sure :-) > I think the first thing to do is to agree on which macro should be used, > ACPI_STATE_D3 or ACPI_STATE_D3_COLD. And then replace the other one > altogether. I'd prefer to use ACPI_STATE_D3 wherever it makes sense, because that's also well defined in older versions of ACPI (think pre-ACPI-4.0 BIOSes). Thanks, Rafael