From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Garrett Subject: Re: [PATCH] PCI / ACPI: Do not request control of ASPM if the BIOS has disabled it Date: Thu, 24 May 2012 21:45:38 +0100 Message-ID: <20120524204538.GA27819@srcf.ucam.org> References: <201205242245.45888.rjw@sisk.pl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from cavan.codon.org.uk ([93.93.128.6]:43115 "EHLO cavan.codon.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756374Ab2EXUpn (ORCPT ); Thu, 24 May 2012 16:45:43 -0400 Content-Disposition: inline In-Reply-To: <201205242245.45888.rjw@sisk.pl> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: "Rafael J. Wysocki" Cc: Bjorn Helgaas , ACPI Devel Mailing List , LKML , linux-pci@vger.kernel.org, Len Brown , Wei Kong , Jean Delvare On Thu, May 24, 2012 at 10:45:45PM +0200, Rafael J. Wysocki wrote: > However, knowing that the BIOS doesn't support ASPM, we shouldn't > request the control of it, so we should remove > (OSC_ACTIVE_STATE_PWR_SUPPORT | OSC_CLOCK_PWR_CAPABILITY_SUPPORT) > from the flags before calling acpi_pci_osc_control_set() in those > cases. Failing to do so causes the evaluation of _OSC for the PCI > root bridge to return error codes on some systems where it should > work correctly. Is there an example of an affected machine's DSDT? -- Matthew Garrett | mjg59@srcf.ucam.org