From: Sarah Sharp <sarah.a.sharp-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: Alan Stern <stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org>
Cc: Lan Tianyu <tianyu.lan-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org,
lenb-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [RFC PATCH V3 3/3] usb : Add sysfs files to control usb port's power
Date: Tue, 5 Jun 2012 08:58:40 -0700 [thread overview]
Message-ID: <20120605155840.GB7534@xanatos> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1206051017040.1542-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
On Tue, Jun 05, 2012 at 10:18:50AM -0400, Alan Stern wrote:
> On Tue, 5 Jun 2012, Lan Tianyu wrote:
>
> > > The patch does not implement anything at all for "auto". It should do
> > > _something_.
> > >
> > Yeah, if we don't power off port without device when echo "auto" > portX/control,
> > this patch does nothing about "auto". Original plan is to deal with port without
> > devices firstly. Do you mean I should add the process of port with device in this
> > patch?
>
> At least make a start. For example, have "auto" turn off the power if
> no device is attached to the port.
Auto should only turn off power if no device is attached to the port
*and* we know it's an internal port through ACPI. Don't forget that
we'll lose port connect events when the power is off.
Sarah Sharp
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-06-05 15:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1338799665-13997-1-git-send-email-tianyu.lan@intel.com>
2012-06-04 8:47 ` [RFC PATCH V3 2/3] USB/ACPI: Add usb port's acpi power control in the xhci PORT_POWER feature request process Lan Tianyu
2012-06-04 8:47 ` [RFC PATCH V3 3/3] usb : Add sysfs files to control usb port's power Lan Tianyu
[not found] ` <1338799665-13997-3-git-send-email-tianyu.lan-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2012-06-04 15:02 ` Alan Stern
[not found] ` <Pine.LNX.4.44L0.1206041040510.1555-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2012-06-05 8:30 ` Lan Tianyu
2012-06-05 14:18 ` Alan Stern
[not found] ` <Pine.LNX.4.44L0.1206051017040.1542-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2012-06-05 15:58 ` Sarah Sharp [this message]
2012-06-06 1:53 ` Lan Tianyu
2012-06-06 14:21 ` Alan Stern
2012-06-07 6:45 ` Lan Tianyu
2012-06-07 14:24 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120605155840.GB7534@xanatos \
--to=sarah.a.sharp-vuqaysv1563yd54fqh9/ca@public.gmane.org \
--cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
--cc=lenb-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org \
--cc=tianyu.lan-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox