From: Thomas Renninger <trenn@suse.de>
To: linux-acpi@vger.kernel.org
Cc: Lin Ming <ming.m.lin@intel.com>,
stable@vger.kernel.org, wallak@free.fr, len.brown@intel.com,
Jiri Slaby <jslaby@suse.cz>
Subject: [PATCH] Fix not loading acpi-cpufreq driver regression
Date: Mon, 25 Jun 2012 13:00:10 +0200 [thread overview]
Message-ID: <201206251300.10957.trenn@suse.de> (raw)
ACPI processor: Only blindly return apic id 0 for real UP systems
This fixes a "not loading acpi-cpufreq driver" regression introduced
by git commit d640113fe80e45ebd4a5b4 on SMP systems where the processor
core with ACPI id zero is disabled
(typically should be the case because of hyperthreading).
The regression got spread through stable kernels.
On 3.0.X it got introduced via 3.0.18.
Such platforms may be rare, but do exist. This problem has been
observed on a:
HP Proliant BL280c G6 blade
This patch restricts the introduced workaround to platforms
with nr_cpu_ids <= 1.
Signed-off-by: Thomas Renninger <trenn@suse.de>
---
drivers/acpi/processor_core.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
Index: linux-3.0-SLE11-SP2/drivers/acpi/processor_core.c
===================================================================
--- linux-3.0-SLE11-SP2.orig/drivers/acpi/processor_core.c
+++ linux-3.0-SLE11-SP2/drivers/acpi/processor_core.c
@@ -201,10 +201,12 @@ int acpi_get_cpuid(acpi_handle handle, i
* Processor (CPU3, 0x03, 0x00000410, 0x06) {}
* }
*
- * Ignores apic_id and always return 0 for CPU0's handle.
+ * Ignores apic_id and always returns 0 for the processor
+ * handle with apic id 0 if nr_cpu_ids is 1.
+ * This should be the case if SMP tables are not found.
* Return -1 for other CPU's handle.
*/
- if (acpi_id == 0)
+ if (nr_cpu_ids <= 1 && acpi_id == 0)
return acpi_id;
else
return apic_id;
next reply other threads:[~2012-06-25 11:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-25 11:00 Thomas Renninger [this message]
2012-06-25 11:20 ` [PATCH] Fix not loading acpi-cpufreq driver regression Thomas Renninger
2012-06-25 14:05 ` Ben Hutchings
2012-06-25 14:39 ` Thomas Renninger
2012-06-25 14:45 ` Ben Hutchings
2012-06-25 15:39 ` [PATCH] Fix not loading acpi-cpufreq driver regression - V2 Thomas Renninger
2012-07-02 9:46 ` Thomas Renninger
-- strict thread matches above, loose matches on Subject: below --
2012-07-11 17:43 [GIT PULL] Power management fix for 3.5-rc7 Rafael J. Wysocki
2012-07-12 8:57 ` Thomas Renninger
2012-07-12 9:03 ` [PATCH] Fix not loading acpi-cpufreq driver regression Thomas Renninger
2012-07-12 20:55 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201206251300.10957.trenn@suse.de \
--to=trenn@suse.de \
--cc=jslaby@suse.cz \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=ming.m.lin@intel.com \
--cc=stable@vger.kernel.org \
--cc=wallak@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox