Re: [PATCH] Fix not loading acpi-cpufreq driver regression

[Thomas Renninger <trenn@suse.de>]

...
> > Such platforms may be rare, but do exist. This problem has been
> > observed on a:
> > HP Proliant BL280c G6 blade
> > This patch restricts the introduced workaround to platforms
> > with nr_cpu_ids <= 1.
> 
> This is not the correct way to submit a patch to stable.  See
> Documentation/stable_kernel_rules.txt.
I guess I should add
CC: stable@vger.kernel.org
in the signed-off area, not in the mail header?

 
> Also, patches to mainline should be made against mainline, not the
> distribution branch you have to hand.
Wow, the diff patched with offset only against a reasonable recent
kernel (3.5-rcX). But yes: It does not anymore after doing a git pull.
I'll resend.

> 
> [...]
> > -                * Ignores apic_id and always return 0 for CPU0's handle.
> > +                * Ignores apic_id and always returns 0 for the processor
> > +                * handle with apic id 0 if nr_cpu_ids is 1.
> > +                * This should be the case if SMP tables are not found.
> [...]
> 
> Second 'apic id' should be 'acpi_id'.
Correct.

Thanks,

   Thomas