public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Thomas Renninger <trenn@suse.de>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Linux PM list <linux-pm@vger.kernel.org>,
	Len Brown <lenb@kernel.org>,
	ACPI Devel Mailing List <linux-acpi@vger.kernel.org>,
	Jonathan Nieder <jrnieder@gmail.com>,
	Lin Ming <ming.m.lin@intel.com>,
	Bob Moore <robert.moore@intel.com>,
	Vlastimil Babka <caster@gentoo.org>
Subject: [PATCH] ACPICA: Fix possible fault in return package object repair code
Date: Thu, 12 Jul 2012 11:00:30 +0200	[thread overview]
Message-ID: <201207121100.30579.trenn@suse.de> (raw)
In-Reply-To: <201207121057.31791.trenn@suse.de>

From: Bob Moore <robert.moore@intel.com>

Fixes a problem that can occur when a lone package object is
wrapped with an outer package object in order to conform to
the ACPI specification. Can affect these predefined names:
_ALR,_MLS,_PSS,_TRT,_TSS,_PRT,_HPX,_DLM,_CSD,_PSD,_TSD

https://bugzilla.kernel.org/show_bug.cgi?id=44171

The bug got introduce by commit 6a99b1c94d053b3420eaa4a4bc
in v3.4-rc6, thus it needs to get pushed into 3.4 stable
kernels as well.

Reported-by: Vlastimil Babka <caster@gentoo.org>
Tested-by: Vlastimil Babka <caster@gentoo.org>
Tested-by: marc.collin@laboiteaprog.com
Signed-off-by: Bob Moore <robert.moore@intel.com>
Signed-off-by: Lin Ming <ming.m.lin@intel.com>
CC: stable@vger.kernel.org

---
 drivers/acpi/acpica/nspredef.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/acpi/acpica/nspredef.c b/drivers/acpi/acpica/nspredef.c
index 23ce096..fe66260 100644
--- a/drivers/acpi/acpica/nspredef.c
+++ b/drivers/acpi/acpica/nspredef.c
@@ -638,7 +638,7 @@ acpi_ns_check_package(struct acpi_predefined_data *data,
 			/* Create the new outer package and populate it */
 
 			status =
-			    acpi_ns_wrap_with_package(data, *elements,
+			    acpi_ns_wrap_with_package(data, return_object,
 						      return_object_ptr);
 			if (ACPI_FAILURE(status)) {
 				return (status);

  reply	other threads:[~2012-07-12  9:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-11 17:43 [GIT PULL] Power management fix for 3.5-rc7 Rafael J. Wysocki
2012-07-12  8:57 ` Thomas Renninger
2012-07-12  9:00   ` Thomas Renninger [this message]
2012-07-12 17:22     ` [PATCH] ACPICA: Fix possible fault in return package object repair code Linus Torvalds
2012-07-12  9:03   ` [PATCH] Fix not loading acpi-cpufreq driver regression Thomas Renninger
2012-07-12 20:55     ` Rafael J. Wysocki
2012-07-12  9:48   ` [GIT PULL] Power management fix for 3.5-rc7 Rafael J. Wysocki
  -- strict thread matches above, loose matches on Subject: below --
2012-07-04  2:02 [PATCH] ACPICA: Fix possible fault in return package object repair code Lin Ming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201207121100.30579.trenn@suse.de \
    --to=trenn@suse.de \
    --cc=caster@gentoo.org \
    --cc=jrnieder@gmail.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=ming.m.lin@intel.com \
    --cc=rjw@sisk.pl \
    --cc=robert.moore@intel.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox