From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: lenb@kernel.org, linux-pm@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: Re: [PATCH 3/5] acpi : remove usage from acpi_processor_cx structure
Date: Thu, 12 Jul 2012 23:45:06 +0200 [thread overview]
Message-ID: <201207122345.06338.rjw@sisk.pl> (raw)
In-Reply-To: <1342127026-1526-3-git-send-email-daniel.lezcano@linaro.org>
On Thursday, July 12, 2012, Daniel Lezcano wrote:
> Remove the usage field as it is not used.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Looks good to me.
Thanks,
Rafael
> ---
> drivers/acpi/processor_idle.c | 5 -----
> include/acpi/processor.h | 1 -
> 2 files changed, 0 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c
> index 9808e60..d044588 100644
> --- a/drivers/acpi/processor_idle.c
> +++ b/drivers/acpi/processor_idle.c
> @@ -761,7 +761,6 @@ static int acpi_idle_enter_c1(struct cpuidle_device *dev,
> dev->last_residency = (int)idle_time;
>
> local_irq_enable();
> - cx->usage++;
> lapic_timer_state_broadcast(pr, cx, 0);
>
> return index;
> @@ -863,8 +862,6 @@ static int acpi_idle_enter_simple(struct cpuidle_device *dev,
> if (cx->entry_method != ACPI_CSTATE_FFH)
> current_thread_info()->status |= TS_POLLING;
>
> - cx->usage++;
> -
> lapic_timer_state_broadcast(pr, cx, 0);
> cx->time += idle_time;
> return index;
> @@ -983,8 +980,6 @@ static int acpi_idle_enter_bm(struct cpuidle_device *dev,
> if (cx->entry_method != ACPI_CSTATE_FFH)
> current_thread_info()->status |= TS_POLLING;
>
> - cx->usage++;
> -
> lapic_timer_state_broadcast(pr, cx, 0);
> cx->time += idle_time;
> return index;
> diff --git a/include/acpi/processor.h b/include/acpi/processor.h
> index d09c94f..0957457 100644
> --- a/include/acpi/processor.h
> +++ b/include/acpi/processor.h
> @@ -59,7 +59,6 @@ struct acpi_processor_cx {
> u8 entry_method;
> u32 latency;
> u32 power;
> - u32 usage;
> u64 time;
> u8 bm_sts_skip;
> char desc[ACPI_CX_DESC_LEN];
>
next prev parent reply other threads:[~2012-07-12 21:39 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-12 21:03 [PATCH 1/5] acpi : remove latency_ticks from acpi_processor_cx structure Daniel Lezcano
2012-07-12 21:03 ` [PATCH 2/5] acpi : remove index " Daniel Lezcano
2012-07-12 21:44 ` Rafael J. Wysocki
2012-07-12 21:57 ` Daniel Lezcano
2012-07-13 18:13 ` Rafael J. Wysocki
2012-07-17 20:32 ` Rafael J. Wysocki
2012-07-17 20:34 ` Rafael J. Wysocki
2012-07-12 21:03 ` [PATCH 3/5] acpi : remove usage " Daniel Lezcano
2012-07-12 21:45 ` Rafael J. Wysocki [this message]
2012-07-17 20:35 ` Rafael J. Wysocki
2012-07-12 21:03 ` [PATCH 4/5] acpi : remove power " Daniel Lezcano
2012-07-12 21:45 ` Rafael J. Wysocki
2012-07-13 0:17 ` Konrad Rzeszutek Wilk
2012-07-13 7:36 ` Daniel Lezcano
2012-07-13 12:23 ` Daniel Lezcano
2012-07-13 18:14 ` Rafael J. Wysocki
2012-07-16 15:23 ` Konrad Rzeszutek Wilk
2012-07-12 21:03 ` [PATCH 5/5] acpi : remove time " Daniel Lezcano
2012-07-12 21:46 ` Rafael J. Wysocki
2012-07-17 20:35 ` Rafael J. Wysocki
2012-07-12 21:40 ` [PATCH 1/5] acpi : remove latency_ticks " Rafael J. Wysocki
2012-07-17 20:32 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201207122345.06338.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=daniel.lezcano@linaro.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).