From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Feng Tang <feng.tang@intel.com>
Cc: len.brown@intel.com, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org, paulmck@linux.vnet.ibm.com,
Thomas Renninger <trenn@suse.de>,
Deepthi Dharwar <deepthi@linux.vnet.ibm.com>
Subject: Re: [PATCH v2] ACPI processor: Fix a typo error in commit 99b725084
Date: Tue, 31 Jul 2012 11:26:53 +0200 [thread overview]
Message-ID: <201207311126.53468.rjw@sisk.pl> (raw)
In-Reply-To: <1343709883-16801-1-git-send-email-feng.tang@intel.com>
On Tuesday, July 31, 2012, Feng Tang wrote:
> In commit 99b725084 "ACPI processor hotplug: Delay acpi_processor_start()
> call for hotplugged cores", acpi_processor_hotplug(pr) was wrongly replaced
> by acpi_processor_cst_has_changed() inside the acpi_cpu_soft_notify(). This
> patch will restore it back, which also fixes a tick_broadcast_mask regression:
> https://lkml.org/lkml/2012/7/30/169
>
> [Resend to ACPI mail list and Cc stable kernel]
>
> Signed-off-by: Feng Tang <feng.tang@intel.com>
> Cc: Thomas Renninger <trenn@suse.de>
> Cc: Deepthi Dharwar <deepthi@linux.vnet.ibm.com>
> Cc: <stable@vger.kernel.org> # 3.3+
Reviewed-by: Rafael J. Wysocki <rjw@sisk.pl>
> ---
> drivers/acpi/processor_driver.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/acpi/processor_driver.c b/drivers/acpi/processor_driver.c
> index ff8e04f..bfc31cb 100644
> --- a/drivers/acpi/processor_driver.c
> +++ b/drivers/acpi/processor_driver.c
> @@ -437,7 +437,7 @@ static int acpi_cpu_soft_notify(struct notifier_block *nfb,
> /* Normal CPU soft online event */
> } else {
> acpi_processor_ppc_has_changed(pr, 0);
> - acpi_processor_cst_has_changed(pr);
> + acpi_processor_hotplug(pr);
> acpi_processor_reevaluate_tstate(pr, action);
> acpi_processor_tstate_has_changed(pr);
> }
>
next prev parent reply other threads:[~2012-07-31 9:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-31 4:44 [PATCH v2] ACPI processor: Fix a typo error in commit 99b725084 Feng Tang
2012-07-31 9:26 ` Rafael J. Wysocki [this message]
2012-07-31 17:18 ` Deepthi Dharwar
2012-08-03 4:22 ` Len Brown
2012-08-03 5:56 ` Srivatsa S. Bhat
2012-08-03 6:03 ` Feng Tang
2012-08-03 6:13 ` Srivatsa S. Bhat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201207311126.53468.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=deepthi@linux.vnet.ibm.com \
--cc=feng.tang@intel.com \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=trenn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).