From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: [linux-pm] [PATCH] ACPI: replace strlen("string") with sizeof("string") -1 Date: Mon, 6 Aug 2012 12:21:14 +0200 Message-ID: <20120806102114.GA31404@elf.ucw.cz> References: <5011F15A.3060007@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:36292 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751316Ab2HFKVR (ORCPT ); Mon, 6 Aug 2012 06:21:17 -0400 Content-Disposition: inline In-Reply-To: <5011F15A.3060007@kernel.org> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Len Brown Cc: Alan Stern , linux-acpi@vger.kernel.org, linux-pm@lists.linux-foundation.org, linux-kernel@vger.kernel.org, Len Brown , Pavel Vasilyev On Thu 2012-07-26 21:39:38, Len Brown wrote: > ...both give the number of chars in the string > without the '\0', as strncmp() wants, > but sizeof() is compile-time. What about introducing something like streq() to do this automatically? This is ugly.... #define streq(a, b) ... if (_buildin_constant(b)) ... ? > - if (!strncmp(val, "enable", strlen("enable"))) { > + if (!strncmp(val, "enable", sizeof("enable") - 1)) { Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html