From: Thomas Renninger <trenn@suse.de>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Michal Pecio <mpecio@nvidia.com>,
"cpufreq@vger.kernel.org" <cpufreq@vger.kernel.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
ACPI Devel Mailing List <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH] cpufreq: ondemand: update frequency when limits are relaxed
Date: Fri, 7 Sep 2012 10:13:56 +0200 [thread overview]
Message-ID: <201209071013.56871.trenn@suse.de> (raw)
In-Reply-To: <201209062340.33610.rjw@sisk.pl>
On Thursday, September 06, 2012 11:40:33 PM Rafael J. Wysocki wrote:
> On Friday, August 31, 2012, Michal Pecio wrote:
> > From: Michal Pecio <mpecio@nvidia.com>
> >
> > Reevaluate CPU load and update frequency immediately whenever limits
> > are changed. Currently ondemand doesn't do so when limits are relaxed,
> > wasting power on CPUs with relatively low sampling rate.
> > Also, update the prev_cpu_* variables on frequency transitions. Their
> > old values aren't valid anymore because the governor assumes constant
> > frequency during entire sampling period.
> >
> > Signed-off-by: Michal Pecio <mpecio@nvidia.com>
>
> Well, this makes sense to me.
>
> Thomas, what do you think?
Looks fine to me as well.
But the same should be done in the conservative driver as well then.
Could you send another, separate patch doing the same in
cpufreq_conservative.c.
Thanks,
Thomas
next prev parent reply other threads:[~2012-09-07 8:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <F22FC3EF73EF0942A7CD99A3AC5E4E1F380AF6B7BF@HQMAIL04.nvidia.com>
2012-09-06 21:40 ` [PATCH] cpufreq: ondemand: update frequency when limits are relaxed Rafael J. Wysocki
2012-09-07 8:13 ` Thomas Renninger [this message]
2012-09-07 20:48 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201209071013.56871.trenn@suse.de \
--to=trenn@suse.de \
--cc=cpufreq@vger.kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mpecio@nvidia.com \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox