From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Renninger Subject: Re: [PATCH] cpufreq: ondemand: update frequency when limits are relaxed Date: Fri, 7 Sep 2012 10:13:56 +0200 Message-ID: <201209071013.56871.trenn@suse.de> References: <201209062340.33610.rjw@sisk.pl> Mime-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <201209062340.33610.rjw@sisk.pl> Sender: cpufreq-owner@vger.kernel.org To: "Rafael J. Wysocki" Cc: Michal Pecio , "cpufreq@vger.kernel.org" , "linux-pm@vger.kernel.org" , ACPI Devel Mailing List List-Id: linux-acpi@vger.kernel.org On Thursday, September 06, 2012 11:40:33 PM Rafael J. Wysocki wrote: > On Friday, August 31, 2012, Michal Pecio wrote: > > From: Michal Pecio > > > > Reevaluate CPU load and update frequency immediately whenever limits > > are changed. Currently ondemand doesn't do so when limits are relaxed, > > wasting power on CPUs with relatively low sampling rate. > > Also, update the prev_cpu_* variables on frequency transitions. Their > > old values aren't valid anymore because the governor assumes constant > > frequency during entire sampling period. > > > > Signed-off-by: Michal Pecio > > Well, this makes sense to me. > > Thomas, what do you think? Looks fine to me as well. But the same should be done in the conservative driver as well then. Could you send another, separate patch doing the same in cpufreq_conservative.c. Thanks, Thomas