From: Jean Delvare <khali@linux-fr.org>
To: "R, Durgadoss" <durgadoss.r@intel.com>
Cc: Guenter Roeck <linux@roeck-us.net>,
"Zhang, Rui" <rui.zhang@intel.com>, Len Brown <lenb@kernel.org>,
lm-sensors@lm-sensors.org, linux-acpi@vger.kernel.org
Subject: Re: CONFIG_THERMAL_HWMON in thermal_sys.c
Date: Tue, 11 Sep 2012 11:49:21 +0200 [thread overview]
Message-ID: <20120911114921.2e39e28c@endymion.delvare> (raw)
In-Reply-To: <4D68720C2E767A4AA6A8796D42C8EB591B72C6@BGSMSX101.gar.corp.intel.com>
On Tue, 11 Sep 2012 09:24:27 +0000, R, Durgadoss wrote:
> I have not tried anything with libsensors until now..so it will take
> some time for me. If you can wait, I can happily submit the required
> patches :-)
>
> But, we are changing the thermal framework quite a bit these days.
> In some time, things should become saner. Until then, we will not
> remove this #define and keep it as it is. Once that happens, we can
> take care of removing this #defined code and also patching
> libsensors.
>
> We can do this now also. I know, we are changing things on
> the thermal side (sysfs attribute names etc..). If we patch
> libsensors now, then we might have to re-visit again, soon.
> That's why, I would like to defer this until things settle down on the
> Thermal side.
>
> Let me know what you think.
I agree, let's wait for the interface to stabilize, there's no point in
updating libsensors publicly now if the interface is going to change in
a near future.
That being said you may also want to anticipate a bit in private, to
make sure that the interface as it exists today is enough for
libsensors.
> > Note: if the same device can now be registered as both hwmon and
> > thermal, we will have to find a way to detect that to avoid duplicate
> > entries in libsensors.
>
> The hwmon sysfs has a 'name' field. We can pass the same string as the
> first argument of the thermal_zone_device_register() call. This will
> show up as 'type' attribute under /sys/class/thermal/thermal_zoneX.
> So, from user space, we can compare these interfaces and thus avoid
> the duplicates.
This is a start, yes. However the name isn't necessarily unique, so
more tricks may be needed.
--
Jean Delvare
next prev parent reply other threads:[~2012-09-11 9:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-11 5:07 CONFIG_THERMAL_HWMON in thermal_sys.c R, Durgadoss
2012-09-11 5:30 ` Guenter Roeck
2012-09-11 8:40 ` R, Durgadoss
2012-09-11 7:12 ` Jean Delvare
2012-09-11 8:55 ` R, Durgadoss
2012-09-11 9:03 ` Jean Delvare
2012-09-11 9:24 ` R, Durgadoss
2012-09-11 9:49 ` Jean Delvare [this message]
2012-09-11 13:45 ` Guenter Roeck
2012-09-11 14:05 ` Jean Delvare
2012-09-11 16:35 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120911114921.2e39e28c@endymion.delvare \
--to=khali@linux-fr.org \
--cc=durgadoss.r@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lm-sensors@lm-sensors.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).