From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean Delvare Subject: Re: CONFIG_THERMAL_HWMON in thermal_sys.c Date: Tue, 11 Sep 2012 11:49:21 +0200 Message-ID: <20120911114921.2e39e28c@endymion.delvare> References: <4D68720C2E767A4AA6A8796D42C8EB591B6F8F@BGSMSX101.gar.corp.intel.com> <20120911091204.24fd1510@endymion.delvare> <4D68720C2E767A4AA6A8796D42C8EB591B7261@BGSMSX101.gar.corp.intel.com> <20120911110335.68009452@endymion.delvare> <4D68720C2E767A4AA6A8796D42C8EB591B72C6@BGSMSX101.gar.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from zoneX.GCU-Squad.org ([194.213.125.0]:30553 "EHLO services.gcu-squad.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758005Ab2IKJtc (ORCPT ); Tue, 11 Sep 2012 05:49:32 -0400 In-Reply-To: <4D68720C2E767A4AA6A8796D42C8EB591B72C6@BGSMSX101.gar.corp.intel.com> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: "R, Durgadoss" Cc: Guenter Roeck , "Zhang, Rui" , Len Brown , lm-sensors@lm-sensors.org, linux-acpi@vger.kernel.org On Tue, 11 Sep 2012 09:24:27 +0000, R, Durgadoss wrote: > I have not tried anything with libsensors until now..so it will take > some time for me. If you can wait, I can happily submit the required > patches :-) > > But, we are changing the thermal framework quite a bit these days. > In some time, things should become saner. Until then, we will not > remove this #define and keep it as it is. Once that happens, we can > take care of removing this #defined code and also patching > libsensors. > > We can do this now also. I know, we are changing things on > the thermal side (sysfs attribute names etc..). If we patch > libsensors now, then we might have to re-visit again, soon. > That's why, I would like to defer this until things settle down on the > Thermal side. > > Let me know what you think. I agree, let's wait for the interface to stabilize, there's no point in updating libsensors publicly now if the interface is going to change in a near future. That being said you may also want to anticipate a bit in private, to make sure that the interface as it exists today is enough for libsensors. > > Note: if the same device can now be registered as both hwmon and > > thermal, we will have to find a way to detect that to avoid duplicate > > entries in libsensors. > > The hwmon sysfs has a 'name' field. We can pass the same string as the > first argument of the thermal_zone_device_register() call. This will > show up as 'type' attribute under /sys/class/thermal/thermal_zoneX. > So, from user space, we can compare these interfaces and thus avoid > the duplicates. This is a start, yes. However the name isn't necessarily unique, so more tricks may be needed. -- Jean Delvare