From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Francesco Lavra <francescolavra.fl@gmail.com>,
lenb@kernel.org, linaro-dev@lists.linaro.org, patches@linaro.org,
pdeschrijver@nvidia.com, linux-pm@vger.kernel.org,
linux-acpi@vger.kernel.org
Subject: Re: [PATCH 4/4] cpuidle - support multiple drivers
Date: Sun, 30 Sep 2012 00:07:49 +0200 [thread overview]
Message-ID: <201209300007.49771.rjw@sisk.pl> (raw)
In-Reply-To: <50673394.5030502@linaro.org>
On Saturday, September 29, 2012, Daniel Lezcano wrote:
> On 09/29/2012 11:41 AM, Francesco Lavra wrote:
> > Hi,
>
> Hi Francesco,
>
> thanks for reviewing the patch.
>
> >> static ssize_t show_current_driver(struct device *dev,
> >> struct device_attribute *attr,
> >> char *buf)
> >> {
> >> - ssize_t ret;
> >> - struct cpuidle_driver *cpuidle_driver = cpuidle_get_driver();
> >> + struct cbarg cbarg = { .buf = buf };
> >
> > cbarg.count should be initialized to 0.
>
> Actually, with this initialization, all the fields will be initialized
> to 0, except 'buf'.
However, it would be good to initialize count explicitly so as to show
that we care about the initial value of it.
Thanks,
Rafael
next prev parent reply other threads:[~2012-09-29 22:01 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-24 22:43 [PATCH 0/4] cpuidle - support multiple drivers at a time Daniel Lezcano
2012-09-24 22:43 ` [PATCH 1/4] cpuidle : move driver's refcount to cpuidle Daniel Lezcano
2012-09-24 22:43 ` [PATCH 2/4] cpuidle : move driver checking within the lock section Daniel Lezcano
[not found] ` <1348526634-19029-3-git-send-email-daniel.lezcano-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2012-10-07 20:17 ` Rafael J. Wysocki
2012-09-24 22:43 ` [PATCH 3/4] cpuidle - prepare the driver core to be multi drivers aware Daniel Lezcano
2012-09-24 22:43 ` [PATCH 4/4] cpuidle - support multiple drivers Daniel Lezcano
[not found] ` <1348526634-19029-5-git-send-email-daniel.lezcano-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2012-09-29 9:41 ` Francesco Lavra
2012-09-29 17:44 ` Daniel Lezcano
2012-09-29 22:07 ` Rafael J. Wysocki [this message]
2012-09-30 16:34 ` Daniel Lezcano
2012-10-02 2:08 ` Rafael J. Wysocki
[not found] ` <3723306.GAm1cPlZaP-sKB8Sp2ER+y1GS7QM15AGw@public.gmane.org>
2012-10-02 12:27 ` Daniel Lezcano
2012-10-02 14:02 ` Rafael J. Wysocki
2012-10-04 14:14 ` Peter De Schrijver
2012-10-04 14:26 ` Daniel Lezcano
2012-10-04 14:34 ` Peter De Schrijver
2012-10-07 21:09 ` Rafael J. Wysocki
2012-10-07 21:26 ` Rafael J. Wysocki
2012-10-11 10:04 ` Daniel Lezcano
2012-10-11 17:21 ` Rafael J. Wysocki
2012-10-11 17:39 ` Daniel Lezcano
2012-10-04 14:16 ` [PATCH 0/4] cpuidle - support multiple drivers at a time Peter De Schrijver
2012-10-04 14:27 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201209300007.49771.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=daniel.lezcano@linaro.org \
--cc=francescolavra.fl@gmail.com \
--cc=lenb@kernel.org \
--cc=linaro-dev@lists.linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=patches@linaro.org \
--cc=pdeschrijver@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).