From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Westerberg Subject: Re: [PATCH 1/3] gpio / ACPI: add ACPI support Date: Wed, 7 Nov 2012 10:54:58 +0200 Message-ID: <20121107085458.GV24532@intel.com> References: <1351928793-14375-1-git-send-email-mika.westerberg@linux.intel.com> <4684026.MA6h34pt1X@vostro.rjw.lan> <2396674.M1Yl70Z09T@vostro.rjw.lan> <20121106093904.GM24532@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mga02.intel.com ([134.134.136.20]:5018 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751380Ab2KGIwj (ORCPT ); Wed, 7 Nov 2012 03:52:39 -0500 Content-Disposition: inline In-Reply-To: Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Linus Walleij , grant.likely@secretlab.ca Cc: "Rafael J. Wysocki" , Mathias Nyman , linux-kernel@vger.kernel.org, lenb@kernel.org, rafael.j.wysocki@intel.com, broonie@opensource.wolfsonmicro.com, khali@linux-fr.org, ben-linux@fluff.org, w.sang@pengutronix.de, linux-acpi@vger.kernel.org On Tue, Nov 06, 2012 at 11:15:21AM +0100, Linus Walleij wrote: > On Tue, Nov 6, 2012 at 10:39 AM, Mika Westerberg > wrote: > > On Mon, Nov 05, 2012 at 03:40:14PM +0100, Linus Walleij wrote: > >> > I forgot to mention that we want to hook up _existing_ drivers to those things, > >> > and they already use the global GPIO numbers, don't they? > >> > >> Yes they do, usually this is either passed from the platform using platform > >> data or handled by device tree lookups to individual drivers. > >> > >> So you will have to modify each such existing driver to do ACPI > >> probe akin to the DT codepath and call acpi_get_gpio() on every pin they > >> need going forward. But that is the plan I guess. > > > > Yes, that's the plan. > > > > Do you think it is OK to go with this implementation (acpi_get_gpio()) for > > now? We will try to make sure that the gpio_get() (or whatever it will be > > called that time) supports ACPI as well. > > Yes I'll be OK with it but I don't dare to merge it unless Grant > ACKs it. Is that an Ack from you? ;-) Since there is a dependency to linux-pm tree (we use the new dev->acpi_handle member) I would like this series merged via that tree. Grant, are you OK with this?