From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Westerberg Subject: Re: [Replacement][PATCH 3/3] Date: Tue, 13 Nov 2012 17:37:25 +0200 Message-ID: <20121113153725.GL31759@intel.com> References: <1351928793-14375-1-git-send-email-mika.westerberg@linux.intel.com> <1956273.aTIDahOxd1@vostro.rjw.lan> <20121113151813.GK31759@intel.com> <3973751.CVDu4LkEMb@vostro.rjw.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mga09.intel.com ([134.134.136.24]:11114 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753801Ab2KMPeQ (ORCPT ); Tue, 13 Nov 2012 10:34:16 -0500 Content-Disposition: inline In-Reply-To: <3973751.CVDu4LkEMb@vostro.rjw.lan> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: "Rafael J. Wysocki" Cc: mathias.nyman@linux.intel.com, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, lenb@kernel.org, rafael.j.wysocki@intel.com, broonie@opensource.wolfsonmicro.com, grant.likely@secretlab.ca, linus.walleij@linaro.org, khali@linux-fr.org, Bjorn Helgaas , "Moore, Robert" On Tue, Nov 13, 2012 at 04:28:50PM +0100, Rafael J. Wysocki wrote: > On Tuesday, November 13, 2012 05:18:13 PM Mika Westerberg wrote: > > On Tue, Nov 13, 2012 at 04:15:51PM +0100, Rafael J. Wysocki wrote: > > > > Could we change this so that you can pass NULL list as well (provided that > > > > the preproc is given)? > > > > > > > > This is useful in case when we try to find the SPI/I2C device handle based > > > > on the ACPI serial bus resource address. In that case we are not interested > > > > in any other resources (and hence there is no need to allocate memory for > > > > them etc.) > > > > > > I'd prefer to have a separate helper function for that, if that's not a > > > problem. It should be clear when we ask for resources of a given device > > > and when we only want to poke things like that. > > > > It's not a problem, we can have a separate helper for that. > > OK > > I suppose you can introduce such a helper in the GPIO patch, then? :-) Actually we don't need that at all - we just need to return 1 from the preproc function and acpi_dev_get_resources() will skip creating the normal resources (altough we still need to pass valid resource_list but that is not a problem).