From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Westerberg Subject: Re: [PATCH] ACPI / resources: Use AE_CTRL_TERMINATE to terminate resources walks Date: Fri, 16 Nov 2012 16:27:58 +0200 Message-ID: <20121116142758.GU17774@intel.com> References: <1453537.D7nc72D9LF@vostro.rjw.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mga09.intel.com ([134.134.136.24]:1333 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752168Ab2KPOYp (ORCPT ); Fri, 16 Nov 2012 09:24:45 -0500 Content-Disposition: inline In-Reply-To: <1453537.D7nc72D9LF@vostro.rjw.lan> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: "Rafael J. Wysocki" Cc: ACPI Devel Maling List , LKML On Fri, Nov 16, 2012 at 02:49:10PM +0100, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > Currently acpi_dev_process_resource() returns AE_ABORT_METHOD > to terminate the acpi_walk_resources() it is called from if > the .preproc() routine provided by the caller of > acpi_dev_get_resources() initiating the resources walk returns > an error code. It is better to use AE_CTRL_TERMINATE for this > purpose, however, so do that. > > Signed-off-by: Rafael J. Wysocki Reviewed-by: Mika Westerberg > --- > drivers/acpi/resource.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Index: linux/drivers/acpi/resource.c > =================================================================== > --- linux.orig/drivers/acpi/resource.c > +++ linux/drivers/acpi/resource.c > @@ -446,7 +446,7 @@ static acpi_status acpi_dev_process_reso > ret = c->preproc(ares, c->preproc_data); > if (ret < 0) { > c->error = ret; > - return AE_ABORT_METHOD; > + return AE_CTRL_TERMINATE; > } else if (ret > 0) { > return AE_OK; > }