From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Westerberg, Mika" Subject: Re: [PATCH] ACPI: remove unnecessary INIT_LIST_HEAD Date: Tue, 27 Nov 2012 11:24:59 +0200 Message-ID: <20121127092458.GO3867@intel.com> References: <1354007025-8334-1-git-send-email-andriy.shevchenko@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mga11.intel.com ([192.55.52.93]:34197 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933261Ab2K0JWI (ORCPT ); Tue, 27 Nov 2012 04:22:08 -0500 Content-Disposition: inline In-Reply-To: <1354007025-8334-1-git-send-email-andriy.shevchenko@linux.intel.com> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Andy Shevchenko Cc: "Rafael J . Wysocki" , linux-acpi@vger.kernel.org On Tue, Nov 27, 2012 at 11:03:45AM +0200, Andy Shevchenko wrote: > There is no need to initialize the node before appending it to the list. I might be missing something but why do we then have macros like: list_del_init() etc? > > Signed-off-by: Andy Shevchenko > --- > drivers/acpi/resource.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c > index 4107c00..a3868f6 100644 > --- a/drivers/acpi/resource.c > +++ b/drivers/acpi/resource.c > @@ -426,7 +426,6 @@ static acpi_status acpi_dev_new_resource_entry(struct resource *r, > c->error = -ENOMEM; > return AE_NO_MEMORY; > } > - INIT_LIST_HEAD(&rentry->node); > rentry->res = *r; > list_add_tail(&rentry->node, c->list); > c->count++; > -- > 1.7.10.4