From: Tejun Heo <tj@kernel.org>
To: Aaron Lu <aaron.lu@intel.com>
Cc: Jeff Garzik <jgarzik@pobox.com>,
Dimitris Damigos <damigos@freemail.gr>,
Matthew Garrett <mjg@redhat.com>, Holger Macht <holger@homac.de>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
linux-ide@vger.kernel.org,
ACPI Devel Mailing List <linux-acpi@vger.kernel.org>,
Aaron Lu <aaron.lwe@gmail.com>
Subject: Re: [PATCH] libata: restore acpi disable functionality
Date: Sun, 2 Dec 2012 06:18:08 -0800 [thread overview]
Message-ID: <20121202141808.GR15930@mtj.dyndns.org> (raw)
In-Reply-To: <50B3044D.4020209@intel.com>
On Mon, Nov 26, 2012 at 01:55:25PM +0800, Aaron Lu wrote:
>
> Commit 66fa7f215 "libata-acpi: improve ACPI disabling" introdcued the
> behaviour of disabling ATA ACPI if ata_acpi_on_devcfg failed the 2nd
> time, but commit 30dcf76ac dropped this behaviour and this caused
> problem for Dimitris Damigos, where his laptop can not resume correctly.
>
> The bugzilla page for it is:
> https://bugzilla.kernel.org/show_bug.cgi?id=49331
>
> The problem is, ata_dev_push_id will fail the 2nd time it is invoked,
> and due to disabling ACPI code is dropped, ata_acpi_on_devcfg which
> calls ata_dev_push_id will keep failing and eventually made the device
> disabled.
>
> This patch restores the original behaviour, if acpi failed the 2nd time,
> disable acpi functionality for the device(and we do not event need to
> add a debug message for this as it is still there ;-).
>
> Reported-by: Dimitris Damigos <damigos@freemail.gr>
> Signed-off-by: Aaron Lu <aaron.lu@intel.com>
> Cc: <stable@vger.kernel.org>
Acked-by: Tejun Heo <tj@kernel.org>
Jeff?
Thanks.
--
tejun
next prev parent reply other threads:[~2012-12-02 14:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-26 5:55 [PATCH] libata: restore acpi disable functionality Aaron Lu
2012-12-02 14:18 ` Tejun Heo [this message]
2012-12-03 9:58 ` Jeff Garzik
2012-12-04 14:05 ` Dimitris Damigos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121202141808.GR15930@mtj.dyndns.org \
--to=tj@kernel.org \
--cc=aaron.lu@intel.com \
--cc=aaron.lwe@gmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=damigos@freemail.gr \
--cc=holger@homac.de \
--cc=jgarzik@pobox.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=mjg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).