From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH] libata: restore acpi disable functionality Date: Sun, 2 Dec 2012 06:18:08 -0800 Message-ID: <20121202141808.GR15930@mtj.dyndns.org> References: <50B3044D.4020209@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-da0-f46.google.com ([209.85.210.46]:33342 "EHLO mail-da0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751275Ab2LBOSN (ORCPT ); Sun, 2 Dec 2012 09:18:13 -0500 Content-Disposition: inline In-Reply-To: <50B3044D.4020209@intel.com> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Aaron Lu Cc: Jeff Garzik , Dimitris Damigos , Matthew Garrett , Holger Macht , Alan Cox , linux-ide@vger.kernel.org, ACPI Devel Mailing List , Aaron Lu On Mon, Nov 26, 2012 at 01:55:25PM +0800, Aaron Lu wrote: > > Commit 66fa7f215 "libata-acpi: improve ACPI disabling" introdcued the > behaviour of disabling ATA ACPI if ata_acpi_on_devcfg failed the 2nd > time, but commit 30dcf76ac dropped this behaviour and this caused > problem for Dimitris Damigos, where his laptop can not resume correctly. > > The bugzilla page for it is: > https://bugzilla.kernel.org/show_bug.cgi?id=49331 > > The problem is, ata_dev_push_id will fail the 2nd time it is invoked, > and due to disabling ACPI code is dropped, ata_acpi_on_devcfg which > calls ata_dev_push_id will keep failing and eventually made the device > disabled. > > This patch restores the original behaviour, if acpi failed the 2nd time, > disable acpi functionality for the device(and we do not event need to > add a debug message for this as it is still there ;-). > > Reported-by: Dimitris Damigos > Signed-off-by: Aaron Lu > Cc: Acked-by: Tejun Heo Jeff? Thanks. -- tejun