* [PATCH] ACPI: add Haswell LPSS devices to acpi_platform_device_ids list
@ 2012-12-07 10:08 Mika Westerberg
2012-12-07 11:01 ` Alan Cox
2012-12-07 22:28 ` Rafael J. Wysocki
0 siblings, 2 replies; 5+ messages in thread
From: Mika Westerberg @ 2012-12-07 10:08 UTC (permalink / raw)
To: linux-acpi; +Cc: Rafael J. Wysocki, Len Brown, linux-kernel, Mika Westerberg
All devices behind Haswell LPSS (Low Power Subsystem) should be represented
as platform devices so add them to the acpi_platform_device_ids list.
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
---
drivers/acpi/scan.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c
index 67a7fa6..8ee379e 100644
--- a/drivers/acpi/scan.c
+++ b/drivers/acpi/scan.c
@@ -37,6 +37,16 @@ static const struct acpi_device_id acpi_platform_device_ids[] = {
{ "PNP0D40" },
+ /* Haswell LPSS devices */
+ { "INT33C0", 0 },
+ { "INT33C1", 0 },
+ { "INT33C2", 0 },
+ { "INT33C3", 0 },
+ { "INT33C4", 0 },
+ { "INT33C5", 0 },
+ { "INT33C6", 0 },
+ { "INT33C7", 0 },
+
{ }
};
--
1.7.10.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] ACPI: add Haswell LPSS devices to acpi_platform_device_ids list
2012-12-07 10:08 [PATCH] ACPI: add Haswell LPSS devices to acpi_platform_device_ids list Mika Westerberg
@ 2012-12-07 11:01 ` Alan Cox
2012-12-07 11:14 ` Mika Westerberg
2012-12-07 22:28 ` Rafael J. Wysocki
1 sibling, 1 reply; 5+ messages in thread
From: Alan Cox @ 2012-12-07 11:01 UTC (permalink / raw)
To: Mika Westerberg; +Cc: linux-acpi, Rafael J. Wysocki, Len Brown, linux-kernel
On Fri, 7 Dec 2012 12:08:02 +0200
Mika Westerberg <mika.westerberg@linux.intel.com> wrote:
> All devices behind Haswell LPSS (Low Power Subsystem) should be represented
> as platform devices
What about the bus heirarchy ? What about making sure they appear in the
PCI resource heirarchy so we don't mash them up if we reassign or
allocate other resources on the bus ?
Alan
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ACPI: add Haswell LPSS devices to acpi_platform_device_ids list
2012-12-07 11:01 ` Alan Cox
@ 2012-12-07 11:14 ` Mika Westerberg
2012-12-07 11:29 ` Alan Cox
0 siblings, 1 reply; 5+ messages in thread
From: Mika Westerberg @ 2012-12-07 11:14 UTC (permalink / raw)
To: Alan Cox; +Cc: linux-acpi, Rafael J. Wysocki, Len Brown, linux-kernel
On Fri, Dec 07, 2012 at 11:01:26AM +0000, Alan Cox wrote:
> On Fri, 7 Dec 2012 12:08:02 +0200
> Mika Westerberg <mika.westerberg@linux.intel.com> wrote:
>
> > All devices behind Haswell LPSS (Low Power Subsystem) should be represented
> > as platform devices
>
> What about the bus heirarchy ? What about making sure they appear in the
> PCI resource heirarchy so we don't mash them up if we reassign or
> allocate other resources on the bus ?
I'm not sure if I understand what you mean here.
We put them in hierarchy if the parent ACPI node has also a physical device
bound to it (like PCIe root port).
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ACPI: add Haswell LPSS devices to acpi_platform_device_ids list
2012-12-07 10:08 [PATCH] ACPI: add Haswell LPSS devices to acpi_platform_device_ids list Mika Westerberg
2012-12-07 11:01 ` Alan Cox
@ 2012-12-07 22:28 ` Rafael J. Wysocki
1 sibling, 0 replies; 5+ messages in thread
From: Rafael J. Wysocki @ 2012-12-07 22:28 UTC (permalink / raw)
To: Mika Westerberg; +Cc: linux-acpi, Rafael J. Wysocki, Len Brown, linux-kernel
On Friday, December 07, 2012 12:08:02 PM Mika Westerberg wrote:
> All devices behind Haswell LPSS (Low Power Subsystem) should be represented
> as platform devices so add them to the acpi_platform_device_ids list.
>
> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Applied.
Thanks,
Rafael
> ---
> drivers/acpi/scan.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c
> index 67a7fa6..8ee379e 100644
> --- a/drivers/acpi/scan.c
> +++ b/drivers/acpi/scan.c
> @@ -37,6 +37,16 @@ static const struct acpi_device_id acpi_platform_device_ids[] = {
>
> { "PNP0D40" },
>
> + /* Haswell LPSS devices */
> + { "INT33C0", 0 },
> + { "INT33C1", 0 },
> + { "INT33C2", 0 },
> + { "INT33C3", 0 },
> + { "INT33C4", 0 },
> + { "INT33C5", 0 },
> + { "INT33C6", 0 },
> + { "INT33C7", 0 },
> +
> { }
> };
>
>
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-12-07 22:23 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-07 10:08 [PATCH] ACPI: add Haswell LPSS devices to acpi_platform_device_ids list Mika Westerberg
2012-12-07 11:01 ` Alan Cox
2012-12-07 11:14 ` Mika Westerberg
2012-12-07 11:29 ` Alan Cox
2012-12-07 22:28 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).