From: Andreas Mohr <andi@lisas.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Borislav Petkov <bp@alien8.de>,
Alan Cox <alan@lxorguk.ukuu.org.uk>, Andreas Mohr <andi@lisas.de>,
linux-kernel@vger.kernel.org, Li Shaohua <shaohua.li@intel.com>,
linux-acpi@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: Look Ma, da kernel is b0rken
Date: Fri, 7 Dec 2012 17:52:18 +0100 [thread overview]
Message-ID: <20121207165218.GA13421@rhlx01.hs-esslingen.de> (raw)
In-Reply-To: <20121205133853.770451ca.akpm@linux-foundation.org>
Hi,
On Wed, Dec 05, 2012 at 01:38:53PM -0800, Andrew Morton wrote:
> Bjorn had a review comment which appears to remain unaddressed:
>
> : The original is definitely broken.
> :
> : I think the corrected test allows PNP IDs containing '@', which
> : doesn't appear legal per sec 6.1.5 of the ACPI 5.0 spec. Should this
> : be
> :
> : + if (!('A' <= (c) && (c) <= 'Z')) \
> :
> : instead?
I hate having to rain on the parade again ;)
I just developed some doubts, by accident again,
by getting dangerously near sound/isa/als100.c snd_als100_pnpids:
there are many IDs with '@' embedded (at least in this ISA-based PnP code),
thus I guess that code may have had its justification (unless ACPI 5.0
is clearly fully authoritative for this space and thus '@' does not have any
business there any more).
Dito e.g. isa/cmi8330.c.
Hmm, anyone deeply familiar with ISA PnP ID magic? :)
Andreas Mohr
next prev parent reply other threads:[~2012-12-07 16:52 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-05 7:09 Look Ma, da kernel is b0rken Andreas Mohr
2012-12-05 14:29 ` Borislav Petkov
2012-12-05 15:27 ` Alan Cox
2012-12-05 15:31 ` Borislav Petkov
2012-12-05 15:47 ` Alan Cox
2012-12-05 15:59 ` Borislav Petkov
2012-12-05 17:04 ` Geert Uytterhoeven
2012-12-05 17:37 ` Borislav Petkov
2012-12-05 20:57 ` Stephen Rothwell
2012-12-05 21:12 ` Borislav Petkov
2012-12-05 21:41 ` Alan Cox
2012-12-05 21:46 ` Borislav Petkov
2012-12-05 21:39 ` Alan Cox
2012-12-05 21:38 ` Andrew Morton
2012-12-05 21:50 ` Borislav Petkov
2012-12-07 16:52 ` Andreas Mohr [this message]
2012-12-07 17:44 ` Borislav Petkov
2012-12-08 7:36 ` Andreas Mohr
2012-12-08 10:52 ` Borislav Petkov
2012-12-08 23:04 ` Alan Cox
2012-12-05 16:39 ` Andreas Mohr
2012-12-05 16:44 ` Borislav Petkov
2012-12-05 17:09 ` Andreas Mohr
2012-12-05 17:34 ` Borislav Petkov
2012-12-05 23:38 ` Rafael J. Wysocki
2012-12-05 23:35 ` Borislav Petkov
2012-12-06 14:04 ` Alan Cox
2012-12-06 20:56 ` Rafael J. Wysocki
2012-12-06 20:59 ` Borislav Petkov
2012-12-06 21:21 ` Rafael J. Wysocki
2012-12-06 21:20 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121207165218.GA13421@rhlx01.hs-esslingen.de \
--to=andi@lisas.de \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=bhelgaas@google.com \
--cc=bp@alien8.de \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox