From mboxrd@z Thu Jan 1 00:00:00 1970 From: Borislav Petkov Subject: Re: Look Ma, da kernel is b0rken Date: Fri, 7 Dec 2012 18:44:05 +0100 Message-ID: <20121207174405.GF27523@liondog.tnic> References: <20121205070901.GA12123@rhlx01.hs-esslingen.de> <20121205142935.GA12119@liondog.tnic> <20121205152756.5afec12c@pyramind.ukuu.org.uk> <20121205153121.GA28556@liondog.tnic> <20121205133853.770451ca.akpm@linux-foundation.org> <20121207165218.GA13421@rhlx01.hs-esslingen.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Received: from mail.skyhub.de ([78.46.96.112]:40031 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1423351Ab2LGRoJ (ORCPT ); Fri, 7 Dec 2012 12:44:09 -0500 Content-Disposition: inline In-Reply-To: <20121207165218.GA13421@rhlx01.hs-esslingen.de> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Andreas Mohr Cc: Andrew Morton , Alan Cox , linux-kernel@vger.kernel.org, Li Shaohua , linux-acpi@vger.kernel.org, Bjorn Helgaas On Fri, Dec 07, 2012 at 05:52:18PM +0100, Andreas Mohr wrote: > I hate having to rain on the parade again ;) I just developed > some doubts, by accident again, by getting dangerously near > sound/isa/als100.c snd_als100_pnpids: there are many IDs with '@' > embedded (at least in this ISA-based PnP code), thus I guess that > code may have had its justification (unless ACPI 5.0 is clearly fully > authoritative for this space and thus '@' does not have any business > there any more). > > Dito e.g. isa/cmi8330.c. > > Hmm, anyone deeply familiar with ISA PnP ID magic? :) Even if this is violating the ACPI spec, any fix for this needs to be tested on the hardware (and I can very well imagine that the hardware might be violating the spec too, nothing new here). So even if you had a fix, you need to run it on the hardware to verify that it actually works. So the actual practical question turns into: do you have such hardware to verify your or anyone else's fix on? Thanks. -- Regards/Gruss, Boris.