From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grant Likely Subject: Re: [PATCH 1/1] gpio: add Lynxpoint chipset gpio driver. Date: Mon, 10 Dec 2012 23:07:49 +0000 Message-ID: <20121210230749.7820F3E081F@localhost> References: <1354888899-21907-1-git-send-email-mathias.nyman@linux.intel.com> <1354888899-21907-2-git-send-email-mathias.nyman@linux.intel.com> Return-path: Received: from mail-we0-f174.google.com ([74.125.82.174]:43662 "EHLO mail-we0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752173Ab2LJXIB (ORCPT ); Mon, 10 Dec 2012 18:08:01 -0500 Received: by mail-we0-f174.google.com with SMTP id x10so1417106wey.19 for ; Mon, 10 Dec 2012 15:08:00 -0800 (PST) In-Reply-To: <1354888899-21907-2-git-send-email-mathias.nyman@linux.intel.com> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: linus.walleij@linaro.org Cc: mika.westerberg@linux.intel.com, rafael.j.wysocki@intel.com, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, Mathias Nyman On Fri, 7 Dec 2012 16:01:39 +0200, Mathias Nyman wrote: > Add gpio support for Intel Lynxpoint chipset. > Lynxpoint supports 94 gpio pins which can generate interrupts. > Driver will fail requests for pins that are marked as owned by ACPI, or > set in an alternate mode (non-gpio). > > Signed-off-by: Mathias Nyman > --- > +static void lp_gpio_set(struct gpio_chip *chip, unsigned gpio, int value) > +{ > + struct lp_gpio *lg = container_of(chip, struct lp_gpio, chip); > + unsigned long reg = gpio_reg(chip, gpio, LP_CONFIG1); > + unsigned long flags; > + > + spin_lock_irqsave(&lg->lock, flags); > + > + if (value) > + outl(inl(reg) | OUT_LVL_BIT, reg); > + else > + outl(inl(reg) & ~OUT_LVL_BIT, reg); > + > + spin_unlock_irqrestore(&lg->lock, flags); > +} A *lot* of drivers implement their own GPIO ops like this, and they all end up looking the same. Please take a look at drivers/gpio/gpio-generic.c and see if you can use the stock operations provided there. g.